Fix items_after_test_module: Ignore imported modules#10719
Merged
bors merged 4 commits intoApr 28, 2023
Conversation
Collaborator
|
r? @Alexendoo (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
Alexendoo
reviewed
Apr 28, 2023
Member
There was a problem hiding this comment.
You can create a test in ui-cargo rather than ui for this, that way the module isn't being itself compiled as a test
Member
There was a problem hiding this comment.
That or put the module in auxiliary and import it with #[path = "auxiliary/tests.rs"] mod tests;
Alexendoo
reviewed
Apr 28, 2023
Alexendoo
reviewed
Apr 28, 2023
Comment on lines
+13
to
+15
| fn should_lint() {} | ||
|
|
||
| const SHOULD_ALSO_LINT: usize = 1; |
Alexendoo
approved these changes
Apr 28, 2023
Member
|
Thanks! @bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10713. It does a little bit of dark magic, but intention is what really counts.
changelog:[
items_after_test_module]: Ignore imported modules (mod foo;) with no body.