Omit lenses for not runnable doctests - #5845
Merged
bors[bot] merged 1 commit intoAug 24, 2020
Merged
Conversation
bjorn3
reviewed
Aug 22, 2020
| fn has_runnable_doc_test(fn_def: &ast::Fn) -> bool { | ||
| fn_def.doc_comment_text().map_or(false, |comments_text| { | ||
| comments_text.contains("```") | ||
| && !comments_text.contains("```ignore") |
Member
There was a problem hiding this comment.
If ```ignore is equivalent to#[ignore]` you can still explicitly run them, or run them by saying that even ignored tests should run.
Contributor
Author
There was a problem hiding this comment.
If I run it explicitly, it does not run it anyway, so I guess I have to use that option somehow:
So it looks like it makes not much sense to keep the lens for it, even there's a way to configure this option somehow globally so it propagates to the lens runners also.
Contributor
|
bors r+ cc #4873, which adds markdown parser |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ideally, we should properly parse the doctest attributes before, but since I need it for the code lens only, this way should suffice for now