render const value in completions label details

[BenjaminBrienen]

I think this would be neat. You may be brutal with the feedback on the code.

[sk0g]

This would be very helpful! RustRover does something similar and it's quite helpful when looking over convenience shortcuts for types you aren't familiar with.

Would it be possible to align the syntax of this a bit more with that of associated type defaults? https://rust-lang.github.io/rfcs/2532-associated-type-defaults.html

Eg

            ct A  = 123  pub const A: i32
// Becomes
            ct A   pub const A: i32 = 123

Edit: actually not sure, looking at the examples in the screenshot, how it works right now would look a lot more reasonable than shoving everything to the right edge.

[BenjaminBrienen]

CI failure is a regression in #23257

[ChayimFriedman2]

You need to rebase on master.

[BenjaminBrienen]

done

[rustbot]

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[ChayimFriedman2]

I think it will be better to display the evaluated const value, like we do in other places (e.g. hover).

View changes since this review

[BenjaminBrienen]

Done. I tried adding a unit test for rendering u32::MAX, but the completion didn't show up at all. It does work, though:

[ChayimFriedman2]

You probably need to include something from minicore.

[BenjaminBrienen]

Ok, I added that under uint_consts. Hopefully the name is ok.

[BenjaminBrienen]

Is "feaures" a typo in rustc? 😂️

[BenjaminBrienen]

rust-lang/rust#162115

[ChayimFriedman2]

Just fix the typos and LGTM.

View changes since this review

[ChayimFriedman2]

You overrode the commit message...

[ChayimFriedman2]

Thanks!

View changes since this review