Skip to content

internal: Add a database lifetime to InternedOpaqueTyId - #22611

Merged
Veykril merged 2 commits into
rust-lang:masterfrom
ada4a:lt-for-interned_opaque_ty_id
Jul 20, 2026
Merged

internal: Add a database lifetime to InternedOpaqueTyId#22611
Veykril merged 2 commits into
rust-lang:masterfrom
ada4a:lt-for-interned_opaque_ty_id

Conversation

@ada4a

@ada4a ada4a commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #22548

cc @Veykril

@ada4a

ada4a commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

@rustbot blocked on #22548, but should be ready otherwise

@rustbot rustbot added the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work. label Jun 18, 2026
@ada4a ada4a changed the title Add a database lifetime to InternedOpaqueTyId internal: Add a database lifetime to InternedOpaqueTyId Jun 18, 2026
@rustbot

This comment has been minimized.

@ada4a
ada4a force-pushed the lt-for-interned_opaque_ty_id branch from 42ebfb0 to 0a54138 Compare June 24, 2026 19:41
@rustbot

This comment has been minimized.

@ada4a
ada4a force-pushed the lt-for-interned_opaque_ty_id branch from 26bb946 to fd9ba16 Compare July 20, 2026 09:05
@ada4a
ada4a marked this pull request as ready for review July 20, 2026 09:05
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 20, 2026
@ada4a ada4a removed the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work. label Jul 20, 2026
@ada4a

ada4a commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

Actually, let me see if I can pull declare_id_wrapper_with_lt into declare_id_wrapper first...

@ada4a
ada4a marked this pull request as draft July 20, 2026 09:11
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 20, 2026
@ada4a

ada4a commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

I fear that would make the resulting macro pretty unreadable... A little bit of duplication might be okay after all

@ada4a
ada4a marked this pull request as ready for review July 20, 2026 09:30
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 20, 2026
@Veykril
Veykril added this pull request to the merge queue Jul 20, 2026
Merged via the queue into rust-lang:master with commit 0069617 Jul 20, 2026
18 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 20, 2026
@ada4a
ada4a deleted the lt-for-interned_opaque_ty_id branch July 20, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants