Clear stage 1#292
Merged
Merged
Conversation
workingjubilee
force-pushed
the
go-green
branch
2 times, most recently
from
September 23, 2020 19:32
456089d to
74619b1
Compare
Merged
Since the project goal has shifted to long-term maintenance and deprecation, denying lints in clippy's "pedantic" segment just adds more overhead.
workingjubilee
force-pushed
the
go-green
branch
from
September 23, 2020 20:19
74619b1 to
c7359ab
Compare
calebzulawski
approved these changes
Sep 23, 2020
workingjubilee
force-pushed
the
go-green
branch
from
September 23, 2020 23:25
4f5c477 to
20c7dc2
Compare
Mostly allowing correct mathematical operations and fixing some pointer casts to clippy's preferences. Also: Remove superfluous unit return Allow mut of const temporaries Use more precise PI const Don't index in loop
workingjubilee
force-pushed
the
go-green
branch
2 times, most recently
from
September 24, 2020 00:04
343b107 to
082a651
Compare
workingjubilee
force-pushed
the
go-green
branch
from
September 24, 2020 00:54
082a651 to
afd985b
Compare
Member
Author
|
Sorry, I should've marked this as a WIP/draft~ It's basically done now though. It doesn't clear stage 2 as of my penultimate commit (it might now?) but it gets to stage 2, which means it builds and can run the examples and benches... and thus, user code! |
Lokathor
approved these changes
Sep 24, 2020
workingjubilee
force-pushed
the
go-green
branch
from
September 24, 2020 02:42
2036b5e to
ee992f4
Compare
calebzulawski
approved these changes
Sep 24, 2020
workingjubilee
force-pushed
the
go-green
branch
from
September 24, 2020 03:11
ee992f4 to
47de491
Compare
Member
Author
|
Shouldn't have tried to keep going into stage 2! Ah well. |
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interesting discovery: packed_simd is incompatible with libm 0.2! (no longer visible, reverted commit)
Fixes #287.