Add chdir shim#960
Merged
Merged
Conversation
oli-obk
requested changes
Sep 24, 2019
oli-obk
left a comment
oli-obk
left a comment
Contributor
There was a problem hiding this comment.
please add a compile-fail test showing that we error for non-utf8 paths by invoking chdir directly from the test
Contributor
Author
OK I added the test :) |
oli-obk
reviewed
Sep 24, 2019
Contributor
|
@bors r+ |
Contributor
|
📌 Commit 145a582 has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-travis, status-appveyor |
RalfJung
reviewed
Oct 10, 2019
RalfJung
reviewed
Oct 10, 2019
RalfJung
reviewed
Oct 10, 2019
RalfJung
reviewed
Oct 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @oli-obk