Skip to content

Add getcwd shim#958

Merged
bors merged 7 commits into
rust-lang:masterfrom
pvdrz:getcwd-shim
Sep 24, 2019
Merged

Add getcwd shim#958
bors merged 7 commits into
rust-lang:masterfrom
pvdrz:getcwd-shim

Conversation

@pvdrz

@pvdrz pvdrz commented Sep 18, 2019

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread src/helpers.rs Outdated
Comment thread src/shims/env.rs Outdated
Comment thread src/shims/env.rs Outdated
Comment thread src/shims/env.rs Outdated
Comment thread src/shims/env.rs Outdated
Comment thread src/shims/env.rs Outdated
Comment thread src/shims/env.rs Outdated
@pvdrz pvdrz requested a review from oli-obk September 20, 2019 07:57
Comment thread src/shims/env.rs Outdated
@pvdrz

pvdrz commented Sep 20, 2019

Copy link
Copy Markdown
Contributor Author

I checked the getcwd implementation and it always generates an error from errno so the unwrap should never fail

Comment thread src/shims/env.rs Outdated
Comment thread src/shims/env.rs Outdated
Comment thread src/shims/env.rs Outdated
Comment thread src/shims/env.rs Outdated
@pvdrz pvdrz requested a review from oli-obk September 24, 2019 14:30
@oli-obk

oli-obk commented Sep 24, 2019

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Sep 24, 2019

Copy link
Copy Markdown
Contributor

📌 Commit 02261e4 has been approved by oli-obk

@bors

bors commented Sep 24, 2019

Copy link
Copy Markdown
Contributor

⌛ Testing commit 02261e4 with merge 2e17933...

bors added a commit that referenced this pull request Sep 24, 2019
@bors

bors commented Sep 24, 2019

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing 2e17933 to master...

@bors bors merged commit 02261e4 into rust-lang:master Sep 24, 2019
Comment thread src/shims/env.rs
Comment thread src/shims/env.rs
Comment thread src/shims/env.rs
Comment thread tests/run-pass/get_current_dir.rs
Comment thread src/shims/env.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants