Skip to content

clippy: fix manual_bits lint #5356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnTitor merged 2 commits into from
Aug 7, 2026
Merged

clippy: fix manual_bits lint #5356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b9b39f
clippy: fix manual_bits lint
xtqqczze Aug 2, 2026
cb3446a
freebsd: use size_of_val for bitset calculations
xtqqczze Aug 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/unix/bsd/freebsdlike/freebsd/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4377,27 +4377,27 @@ f! {
}

pub unsafe fn CPU_SET(cpu: usize, cpuset: &mut cpuset_t) -> () {
let bitset_bits = 8 * size_of::<c_long>();
let bitset_bits = 8 * size_of_val(&cpuset.__bits[0]);
let (idx, offset) = (cpu / bitset_bits, cpu % bitset_bits);
cpuset.__bits[idx] |= 1 << offset;
}

pub unsafe fn CPU_CLR(cpu: usize, cpuset: &mut cpuset_t) -> () {
let bitset_bits = 8 * size_of::<c_long>();
let bitset_bits = 8 * size_of_val(&cpuset.__bits[0]);
let (idx, offset) = (cpu / bitset_bits, cpu % bitset_bits);
cpuset.__bits[idx] &= !(1 << offset);
}

pub unsafe fn CPU_ISSET(cpu: usize, cpuset: &cpuset_t) -> bool {
let bitset_bits = 8 * size_of::<c_long>();
let bitset_bits = 8 * size_of_val(&cpuset.__bits[0]);
let (idx, offset) = (cpu / bitset_bits, cpu % bitset_bits);
0 != cpuset.__bits[idx] & (1 << offset)
}

pub unsafe fn CPU_COUNT(cpuset: &cpuset_t) -> c_int {
let mut s: u32 = 0;
let cpuset_size = size_of::<cpuset_t>();
let bitset_size = size_of::<c_long>();
let bitset_size = size_of_val(&cpuset.__bits[0]);
for i in &cpuset.__bits[..(cpuset_size / bitset_size)] {
s += i.count_ones();
}
Expand Down
2 changes: 1 addition & 1 deletion src/unix/hurd/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2579,7 +2579,7 @@ pub const SCHED_FIFO: c_int = 1;
pub const SCHED_RR: c_int = 2;
pub const _BITS_TYPES_STRUCT_SCHED_PARAM: usize = 1;
pub const __CPU_SETSIZE: usize = 1024;
pub const __NCPUBITS: usize = 8 * size_of::<__cpu_mask>();
pub const __NCPUBITS: usize = __cpu_mask::BITS as usize;
pub const CPU_SETSIZE: usize = 1024;

// pthread.h
Expand Down