Add __errno for newlib targets - #5346
Conversation
1c7c05b to
202dc16
Compare
|
@rustbot ready |
rustbot
added
the
stable-nominated
|
Error: Label ready can only be set by Rust team members Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip. |
|
hey @tgross35, the errno pr is up #5346 ci is red but not the pr, the 07/30 nightly cargo changed the build dir layout rust-lang/cargo#15010 and ctest t1 t2 broke, main is red too https://github.com/rust-lang/libc/actions/runs/30618425289 could you look.. |
This comment was marked as outdated.
This comment was marked as outdated.
?? |
newlib errno is (*__errno()) so rust needs this to read errno. std already links it on newlib source https://www.sourceware.org/git/?p=newlib-cygwin.git;a=blob;f=newlib/libc/include/sys/errno.h;hb=b6624e23e17bdc505f639d9f181225dbf3a50fc6
4da9750 to
8bbc391
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@tgross35 If you could get this backported and included in a release, that would be great. This is currently blocking the |
|
It has the stable-nominated label, it will get picked up. Usually I target a release every ~6-8 weeks. |
tgross35
added
stable-applied
newlib errno is (*__errno()) so rust needs this to read errno. std already links it on newlib source https://www.sourceware.org/git/?p=newlib-cygwin.git;a=blob;f=newlib/libc/include/sys/errno.h;hb=b6624e23e17bdc505f639d9f181225dbf3a50fc6 (backport <rust-lang#5346>) (cherry picked from commit 8428e69)
(backport <rust-lang#5346>) (cherry picked from commit 5c472fb)
4 participants
newlib errno is (*__errno()) so rust needs this to read errno on newlib targets. std already links the symbol
source newlib sys/errno.h
https://github.com/eblot/newlib/blob/master/newlib/libc/include/sys/errno.h
Closes #1995