style: run rustfmt with nightly toolchain in ci/style.py - #5340
Merged
Conversation
tgross35
reviewed
Jul 30, 2026
| # if `CI` is set, do a check rather than overwriting | ||
| check_only = os.getenv("CI") is not None | ||
| run(["rustfmt", "-V"]) | ||
| run(["rustup", "run", "nightly", "rustfmt", "-V"]) |
Member
There was a problem hiding this comment.
Checking locally, it seems like rustfmt +nightly should work
ssenthilnathan3
force-pushed
the
style/nightly-rustfmt
branch
from
July 31, 2026 04:36
ec95343 to
d91a5d6
Compare
tgross35
added
the
stable-nominated
tgross35
approved these changes
Jul 31, 2026
tgross35
enabled auto-merge
July 31, 2026 04:38
auto-merge was automatically disabled
July 31, 2026 04:38
Head branch was pushed to by a user without write access
ssenthilnathan3
force-pushed
the
style/nightly-rustfmt
branch
2 times, most recently
from
July 31, 2026 04:38
9e171ac to
3534200
Compare
This comment was marked as outdated.
This comment was marked as outdated.
tgross35
enabled auto-merge
August 2, 2026 19:30
tgross35
force-pushed
the
style/nightly-rustfmt
branch
from
August 2, 2026 19:30
3534200 to
cb1954d
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Merged
tgross35
added
stable-applied
tgross35
pushed a commit
to dybucc/libc
that referenced
this pull request
Aug 31, 2026
(backport <rust-lang#5340>) (cherry picked from commit 866b642)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the ci/style.py script to automatically invoke
rustfmtandcargo fmtwith a nightly toolchain viarustup, so contributors don't need tofigure this out manually.
Closes #5324