ci: Select cuttlefish by target instead of a matrix env - #5316
Merged
Conversation
The x86_64-linux-android job set TEST_CUTTLEFISH=1 in the workflow matrix just so run-docker.sh could tell it apart. Match on the target name instead, like the existing musl and aarch64-linux-android checks, so the CI matrix carries no magic env and running the job locally needs no special variable. Suggested-by: Trevor Gross <tg@trevorgross.com> Assisted-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>
tgross35
approved these changes
Jul 23, 2026
tgross35
enabled auto-merge
July 23, 2026 18:20
tgross35
added
the
stable-nominated
Merged
tgross35
added
stable-applied
tgross35
pushed a commit
to dybucc/libc
that referenced
this pull request
Aug 31, 2026
The x86_64-linux-android job set TEST_CUTTLEFISH=1 in the workflow matrix just so run-docker.sh could tell it apart. Match on the target name instead, like the existing musl and aarch64-linux-android checks, so the CI matrix carries no magic env and running the job locally needs no special variable. Suggested-by: Trevor Gross <tg@trevorgross.com> Assisted-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com> (backport <rust-lang#5316>) (cherry picked from commit aa2e589)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This is a tiny follow-up to #5269 at @tgross35's request: drop the
TEST_CUTTLEFISH=1matrix env and select Cuttlefish by matchingx86_64-linux-androidinrun-docker.sh, like the existing musl/aarch64 target checks.A libc-0.2 backport might be desired to get the new Android CI infra there as well, but I'll leave it up to the maintainers / reviewers to decide.
Sources
No library/API changes; this is test-harness and CI-only.
Checklist
CI-only change: no
src/orlibc-test/semvermodifications.Relevant tests in(N/A)libc-test/semverhave been updatedNo placeholder or unstable values(N/A)AI disclosure
This PR was written with the help of Claude Code, but was not vibe-coded. I'm not a fan of vibe-coding.
I used AI to better understand the codebase myself (asked it a lot of questions), review both my code and any code generated by AI, used it especially to detect bugs and corner-cases and suggest fixes, however I very carefully reviewed & edited each code/comment lines, the commit messages and so on, until I was satisfied with the result.
Even this PR description was written entirely by myself and only reviewed by AI for errors.