Add RFC 3678 multicast group_req/group_source_req and MCAST_* - #5236
Merged
Conversation
Collaborator
|
Some changes occurred in an Android module cc @maurer |
rustbot
added
S-waiting-on-review
stable-nominated
Member
|
@sbogomolov do you actually have a use these constants? Three PRs in the past few hours is a lot. Also, these PR descriptions look like they may be AI-generated. Please handwrite all PR descriptions and commit messages, and make sure to include the information requested in the PR template. |
Contributor
Author
I actually use these, yes :) Not every single constant is used by me, but I thought it would make sense to add related constants together. They are used in my reflector project (mDNS, SSDP/DIAL, WoL). I'm trying to create PRs for all constants / structs that I had to manually define. |
sbogomolov
marked this pull request as draft
July 1, 2026 08:59
sbogomolov
force-pushed
the
rfc3678-multicast
branch
from
July 1, 2026 10:43
6bf280f to
c08df52
Compare
sbogomolov
marked this pull request as ready for review
July 1, 2026 11:26
sbogomolov
force-pushed
the
rfc3678-multicast
branch
from
July 2, 2026 11:55
c08df52 to
4a5c221
Compare
This comment has been minimized.
This comment has been minimized.
sbogomolov
force-pushed
the
rfc3678-multicast
branch
from
July 7, 2026 13:15
4a5c221 to
e2fc905
Compare
This comment has been minimized.
This comment has been minimized.
sbogomolov
force-pushed
the
rfc3678-multicast
branch
from
July 9, 2026 16:03
e2fc905 to
5383022
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@tgross35 for this one I did not move anything to |
sbogomolov
force-pushed
the
rfc3678-multicast
branch
from
July 18, 2026 22:01
5383022 to
0635d1e
Compare
This comment has been minimized.
This comment has been minimized.
|
Change fine for Android, just regular libc stuff to look at. |
Add the protocol-independent multicast group membership request structs `group_req` and `group_source_req` (RFC 3678) on Linux, Apple, and FreeBSD, and the `MCAST_*` socket-option constants on Apple and FreeBSD (Linux already defines them). Apple wraps the structs in `#pragma pack(4)`, so they are `#[repr(packed(4))]` there; Linux and FreeBSD use natural alignment. DragonFly lacks the RFC 3678 multicast API, so it is excluded.
sbogomolov
force-pushed
the
rfc3678-multicast
branch
from
August 2, 2026 19:42
0635d1e to
c7a8210
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
tgross35
approved these changes
Aug 4, 2026
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Aug 31, 2026
Add the protocol-independent multicast group membership request structs `group_req` and `group_source_req` (RFC 3678) on Linux, Apple, and FreeBSD, and the `MCAST_*` socket-option constants on Apple and FreeBSD (Linux already defines them). Apple wraps the structs in `#pragma pack(4)`, so they are `#[repr(packed(4))]` there; Linux and FreeBSD use natural alignment. DragonFly lacks the RFC 3678 multicast API, so it is excluded. (backport <rust-lang#5236>) (cherry picked from commit 605ebff)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Aug 31, 2026
Add the protocol-independent multicast group membership request structs `group_req` and `group_source_req` (RFC 3678) on Linux, Apple, and FreeBSD, and the `MCAST_*` socket-option constants on Apple and FreeBSD (Linux already defines them). Apple wraps the structs in `#pragma pack(4)`, so they are `#[repr(packed(4))]` there; Linux and FreeBSD use natural alignment. DragonFly lacks the RFC 3678 multicast API, so it is excluded. (backport <rust-lang#5236>) (cherry picked from commit 605ebff)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Aug 31, 2026
Add the protocol-independent multicast group membership request structs `group_req` and `group_source_req` (RFC 3678) on Linux, Apple, and FreeBSD, and the `MCAST_*` socket-option constants on Apple and FreeBSD (Linux already defines them). Apple wraps the structs in `#pragma pack(4)`, so they are `#[repr(packed(4))]` there; Linux and FreeBSD use natural alignment. DragonFly lacks the RFC 3678 multicast API, so it is excluded. (backport <rust-lang#5236>) (cherry picked from commit 605ebff)
Merged
tgross35
added
stable-applied
tgross35
pushed a commit
to dybucc/libc
that referenced
this pull request
Aug 31, 2026
Add the protocol-independent multicast group membership request structs `group_req` and `group_source_req` (RFC 3678) on Linux, Apple, and FreeBSD, and the `MCAST_*` socket-option constants on Apple and FreeBSD (Linux already defines them). Apple wraps the structs in `#pragma pack(4)`, so they are `#[repr(packed(4))]` there; Linux and FreeBSD use natural alignment. DragonFly lacks the RFC 3678 multicast API, so it is excluded. (backport <rust-lang#5236>) (cherry picked from commit 605ebff)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
group_req/group_source_reqand theMCAST_*socket options for the protocol-independent multicast API (RFC 3678) on Linux, Apple, and FreeBSD. Linux already had theMCAST_*constants. Apple needs#[repr(packed(4))]since the structs are under#pragma pack(4)there. DragonFly doesn't have this API, so it's FreeBSD-only.Sources
Linux
group_req/group_source_req(linux/in.h):Apple
group_req/group_source_req/MCAST_*(netinet/in.h):FreeBSD
group_req/group_source_req/MCAST_*(netinet/in.h):Checklist
libc-test/semverhave been updated*LASTor*MAXare includedcd libc-test && cargo test --target mytarget)