Repository navigation
[beta-1.100] fix: check crate type when pruning -L paths - #17590
Merged
Merged
Conversation
During manifest parsing, explicit `crate-type` wins over `proc-macro=true` when invoking rustc, though `Target::proc_macro` still returns true for such a library. Since rust-lang#17410, our `-L` dependency walk stops at proc-macro targets, so dependencies of that "ordinary" rlib were no longer searchable. And then we got E0463 This patch checks crate type rustc actually set rather than the `target.proc-macro` flag. The scope of this fix is intentionally kept minimal for backport. Fixes rust-lang/rust#164086 See also rust-lang#17579
rustbot
added
A-build-execution
Collaborator
|
r? @epage rustbot has assigned @epage. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Collaborator
|
Our doc-merge rustdoc invocation didn't pass `--edition` hence affected by rust-lang/rust#163795
Muscraft
approved these changes
Oct 14, 2026
rustbot
removed
the
S-waiting-on-review
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Oct 15, 2026
[beta-1.100] Update cargo submodule 1 commits in 7552a885e7c68a5b5a3dfc5c158059983ac3efb7..ec94eef9b5d25d89158c02a449b7d838a5ad3f43 2026-09-29 18:08:50 -0400 to 2026-10-14 12:58:33 -0600 - [beta-1.100] fix: check crate type when pruning `-L` paths (rust-lang/cargo#17590) Fixes #164086
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Oct 15, 2026
[beta-1.100] Update cargo submodule 1 commits in 7552a885e7c68a5b5a3dfc5c158059983ac3efb7..ec94eef9b5d25d89158c02a449b7d838a5ad3f43 2026-09-29 18:08:50 -0400 to 2026-10-14 12:58:33 -0600 - [beta-1.100] fix: check crate type when pruning `-L` paths (rust-lang/cargo#17590) Fixes #164086
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Oct 17, 2026
[beta-1.100] Update cargo submodule 2 commits in 7552a885e7c68a5b5a3dfc5c158059983ac3efb7..72b77b8d94ec3e2fca533266d88561e527aabe25 2026-09-29 18:08:50 -0400 to 2026-10-17 10:39:00 -0400 - [beta 1.100] fix(config): Apply dotted tuple support for rustflags (rust-lang/cargo#17605) - [beta-1.100] fix: check crate type when pruning `-L` paths (rust-lang/cargo#17590) Fixes #164086
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beta backports
-Lpaths #17589In order to make CI pass, the following PRs are also cherry-picked: