Repository navigation
refactor(context): Split config keys in code, not at runtime - #17490
Merged
Merged
Conversation
This avoids - problems with proper splitting - reduces work (even if its minor) This may have fixed rust-lang#15901 but haven't looked into how to test it. Unsure if it helped with environment variables. This does not help with `cargo config get`: `ConfigKey::from_str` should be switched to using a TOML key parser.
Collaborator
|
r? @Muscraft rustbot has assigned @Muscraft. Use Why was this reviewer chosen?The reviewer was selected based on:
|
rustbot
added
A-cfg-expr
weihanglo
approved these changes
Sep 20, 2026
| @@ -136,7 +136,7 @@ fn builtin_aliases_execs(cmd: &str) -> Option<&(&str, &str, &str)> { | |||
| /// 3. If still cannot find any, finds one insides [`BUILTIN_ALIASES`]. | |||
| fn aliased_command(gctx: &GlobalContext, command: &str) -> CargoResult<Option<Vec<String>>> { | |||
| let alias_name = format!("alias.{}", command); | |||
Member
There was a problem hiding this comment.
nit: Should we move this format! to the use site later?
rustbot
removed
the
S-waiting-on-review
4 of 6 tasks
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Sep 22, 2026
Update cargo submodule 10 commits in 495c385d0875c4ba51eb72ea0448a2d4c018b8d4..98a09e7e7d62850f14e5b6132101fc1edd19a16f 2026-09-16 12:48:58 +0000 to 2026-09-21 19:03:16 +0000 - feat(build-rs): trim-paths inputs (rust-lang/cargo#17491) - Remove README CI badge (rust-lang/cargo#17495) - feat(builtin-deps): Add unstable `builtin-dependencies` feature (rust-lang/cargo#17497) - test(prerelease): concurrent downloads snapshots be unordered (rust-lang/cargo#17492) - Account for (uplift) hardlinks when calculating clean file size (rust-lang/cargo#17485) - feat(hints): extract mostly-unused diagnostics (rust-lang/cargo#17457) - fix(build-rs): make `unstable` compile (rust-lang/cargo#17489) - refactor(context): Split config keys in code, not at runtime (rust-lang/cargo#17490) - fix(prerelease): preserve locked prerelease deps (rust-lang/cargo#17464) - Remove -Zasymmetric-token / cargo:paseto (rust-lang/cargo#17486) r? ghost
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Sep 23, 2026
Update cargo submodule 10 commits in 495c385d0875c4ba51eb72ea0448a2d4c018b8d4..98a09e7e7d62850f14e5b6132101fc1edd19a16f 2026-09-16 12:48:58 +0000 to 2026-09-21 19:03:16 +0000 - feat(build-rs): trim-paths inputs (rust-lang/cargo#17491) - Remove README CI badge (rust-lang/cargo#17495) - feat(builtin-deps): Add unstable `builtin-dependencies` feature (rust-lang/cargo#17497) - test(prerelease): concurrent downloads snapshots be unordered (rust-lang/cargo#17492) - Account for (uplift) hardlinks when calculating clean file size (rust-lang/cargo#17485) - feat(hints): extract mostly-unused diagnostics (rust-lang/cargo#17457) - fix(build-rs): make `unstable` compile (rust-lang/cargo#17489) - refactor(context): Split config keys in code, not at runtime (rust-lang/cargo#17490) - fix(prerelease): preserve locked prerelease deps (rust-lang/cargo#17464) - Remove -Zasymmetric-token / cargo:paseto (rust-lang/cargo#17486) r? ghost
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Sep 23, 2026
Update cargo submodule 10 commits in 495c385d0875c4ba51eb72ea0448a2d4c018b8d4..98a09e7e7d62850f14e5b6132101fc1edd19a16f 2026-09-16 12:48:58 +0000 to 2026-09-21 19:03:16 +0000 - feat(build-rs): trim-paths inputs (rust-lang/cargo#17491) - Remove README CI badge (rust-lang/cargo#17495) - feat(builtin-deps): Add unstable `builtin-dependencies` feature (rust-lang/cargo#17497) - test(prerelease): concurrent downloads snapshots be unordered (rust-lang/cargo#17492) - Account for (uplift) hardlinks when calculating clean file size (rust-lang/cargo#17485) - feat(hints): extract mostly-unused diagnostics (rust-lang/cargo#17457) - fix(build-rs): make `unstable` compile (rust-lang/cargo#17489) - refactor(context): Split config keys in code, not at runtime (rust-lang/cargo#17490) - fix(prerelease): preserve locked prerelease deps (rust-lang/cargo#17464) - Remove -Zasymmetric-token / cargo:paseto (rust-lang/cargo#17486) r? ghost
pull Bot
pushed a commit
to xtqqczze/rust-lang-miri
that referenced
this pull request
Sep 24, 2026
Update cargo submodule 10 commits in 495c385d0875c4ba51eb72ea0448a2d4c018b8d4..98a09e7e7d62850f14e5b6132101fc1edd19a16f 2026-09-16 12:48:58 +0000 to 2026-09-21 19:03:16 +0000 - feat(build-rs): trim-paths inputs (rust-lang/cargo#17491) - Remove README CI badge (rust-lang/cargo#17495) - feat(builtin-deps): Add unstable `builtin-dependencies` feature (rust-lang/cargo#17497) - test(prerelease): concurrent downloads snapshots be unordered (rust-lang/cargo#17492) - Account for (uplift) hardlinks when calculating clean file size (rust-lang/cargo#17485) - feat(hints): extract mostly-unused diagnostics (rust-lang/cargo#17457) - fix(build-rs): make `unstable` compile (rust-lang/cargo#17489) - refactor(context): Split config keys in code, not at runtime (rust-lang/cargo#17490) - fix(prerelease): preserve locked prerelease deps (rust-lang/cargo#17464) - Remove -Zasymmetric-token / cargo:paseto (rust-lang/cargo#17486) r? ghost
epage
added a commit
to epage/cargo
that referenced
this pull request
Sep 29, 2026
This verifies that rust-lang#17490 partially fixed rust-lang#15901
epage
added a commit
to epage/cargo
that referenced
this pull request
Sep 29, 2026
…rk again This is the needed other half of rust-lang#17490 Fixes rust-lang#15901
epage
added a commit
to epage/cargo
that referenced
this pull request
Sep 29, 2026
This verifies that rust-lang#17490 partially fixed rust-lang#15901
epage
added a commit
to epage/cargo
that referenced
this pull request
Sep 29, 2026
…rk again This is the needed other half of rust-lang#17490 Fixes rust-lang#15901
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This avoids
This may address #15901 but haven't looked into how to test it. Unsure if it helped with environment variables.
This does not help with
cargo config get:ConfigKey::from_strshould be switched to using a TOML key parser.How to test and review this PR?