feat(hints): support minimum optimization levels by 0xPoe · Pull Request #17368 · rust-lang/cargo

0xPoe · 2026-08-16T09:10:26Z

What does this PR try to resolve?

This PR would allow Rust library to provide a simple hint about the minimum opt-level to build them with via the hint.min-opt-level setting in the manifest.

How to test and review this PR?

Check the unit tests and review it commit by commit.

r?@ghost

0xPoe

🔢 Self-check (PR reviewed by myself and ready for feedback)

Code compiles successfully
Unit tests added
No AI-generated elegant nonsense in PR.
Comments added where necessary
PR title and description updated
Documentation updated
PR size is reasonable

r?@joshtriplett

View changes since this review

epage

Feel free to merge one the conflicts are resolved

View changes since this review

Record the current ignored-hint behavior across the RFC precedence, scope, validation, and boundary cases. Signed-off-by: 0xPoe <poe.liu@pm.me>

Validating `hints.min-opt-level` only needs the manifest, so run it as a package rule in the parse pass instead of walking the pre-build unit graph. Non-member path dependencies stop being diagnosed, matching how unused manifest keys and unknown hints are already reported. Signed-off-by: 0xPoe <poe.liu@pm.me>

Signed-off-by: 0xPoe <poe.liu@pm.me>

rustbot · 2026-10-06T15:50:39Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

0xPoe · 2026-10-06T15:51:28Z

Thanks for your review! 💚 💙 💜 💛 ❤️

Update cargo submodule 11 commits in f3865b2a4d1acc5276f6b3c67d0e057f4dab3928..45c3aacf0e8dabdcdb6b7b518db100061d6367a7 2026-09-29 19:58:08 +0000 to 2026-10-06 16:29:08 +0000 - feat(pkgid-spec): Builtin package spec parsing and formatting (rust-lang/cargo#17539) - feat(hints): support minimum optimization levels (rust-lang/cargo#17368) - Use trusted publishing for Cargo crates (rust-lang/cargo#17426) - feat(trim-paths): stabilize `profile.trim-paths` (rust-lang/cargo#17488) - fix(pkgid): avoid panic on malformed protocol URLs (rust-lang/cargo#17548) - fix(git)!: Default to net.git-fetch-with-cli if git is present (rust-lang/cargo#17329) - Improved testsuite file permissions cleanup (rust-lang/cargo#17547) - docs(guide): Give an example of checking for stale lockfile (rust-lang/cargo#17546) - Add new peak memory table to cargo timings enabled via `-Zmem-stats` (rust-lang/cargo#17531) - docs(changlog): Update 1.100.0 to reflect a beta backport (rust-lang/cargo#17542) - feat(lint): Making the lint name a terminal hyperlink to docs (rust-lang/cargo#17538)

Update cargo submodule 15 commits in f3865b2a4d1acc5276f6b3c67d0e057f4dab3928..29c5daa1afc262323364e039bb70c83372cc702c 2026-09-29 19:58:08 +0000 to 2026-10-07 22:13:48 +0000 - test: mark requiring ssh for tests shelling out to it (rust-lang/cargo#17563) - chore(deps): update msrv (rust-lang/cargo#17532) - fix(rustdoc): suppress edition unspecified warnings (rust-lang/cargo#17557) - chore(deps): update cargo-semver-checks to v0.51.0 (rust-lang/cargo#17553) - feat(pkgid-spec): Builtin package spec parsing and formatting (rust-lang/cargo#17539) - feat(hints): support minimum optimization levels (rust-lang/cargo#17368) - Use trusted publishing for Cargo crates (rust-lang/cargo#17426) - feat(trim-paths): stabilize `profile.trim-paths` (rust-lang/cargo#17488) - fix(pkgid): avoid panic on malformed protocol URLs (rust-lang/cargo#17548) - fix(git)!: Default to net.git-fetch-with-cli if git is present (rust-lang/cargo#17329) - Improved testsuite file permissions cleanup (rust-lang/cargo#17547) - docs(guide): Give an example of checking for stale lockfile (rust-lang/cargo#17546) - Add new peak memory table to cargo timings enabled via `-Zmem-stats` (rust-lang/cargo#17531) - docs(changlog): Update 1.100.0 to reflect a beta backport (rust-lang/cargo#17542) - feat(lint): Making the lint name a terminal hyperlink to docs (rust-lang/cargo#17538)

0xPoe changed the title ~~feat(hints): support minimum optimization levels~~ WIP: feat(hints): support minimum optimization levels Aug 16, 2026

0xPoe changed the title ~~WIP: feat(hints): support minimum optimization levels~~ WIP(Not Ready For Review): feat(hints): support minimum optimization levels Aug 16, 2026

0xPoe force-pushed the hint-min-opt-level branch 7 times, most recently from b532a3f to 2b19c48 Compare August 21, 2026 07:18

0xPoe commented Aug 21, 2026

View reviewed changes

Comment thread crates/cargo-util-schemas/Cargo.toml Outdated

Comment thread crates/cargo-util-schemas/manifest.schema.json

Comment thread src/workspace/profiles.rs Outdated

rustbot assigned joshtriplett Aug 21, 2026

0xPoe changed the title ~~WIP(Not Ready For Review): feat(hints): support minimum optimization levels~~ feat(hints): support minimum optimization levels Aug 21, 2026

0xPoe marked this pull request as ready for review August 21, 2026 07:20

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 21, 2026