Skip to content

fix(clean): Improving description for clean options - #17365

Merged
ranger-ross merged 1 commit into
rust-lang:masterfrom
Suryansh-Dey:master
Aug 18, 2026
Merged

fix(clean): Improving description for clean options#17365
ranger-ross merged 1 commit into
rust-lang:masterfrom
Suryansh-Dey:master

Conversation

@Suryansh-Dey

@Suryansh-Dey Suryansh-Dey commented Aug 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR try to resolve?

Closes issue #17129
Changes:

  1. The find and replace of description as mentioned in issue description.
  2. Used "only" in description as recommended by author here and also fixed the doc description.

How to test and review this PR?

Run man etc/man/cargo-clean.1
image

Run cargo run -- clean -h
Output

Run cargo test clean::help and this passes

@rustbot rustbot added A-cli Area: Command-line interface, option parsing, etc. A-cli-help Area: built-in command-line help A-documenting-cargo-itself Area: Cargo's documentation Command-clean S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2026
@rustbot

rustbot commented Aug 15, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @epage (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue
Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @epage, @weihanglo
  • @epage, @weihanglo expanded to epage, weihanglo
  • Random selection from epage, weihanglo

@Suryansh-Dey Suryansh-Dey mentioned this pull request Aug 15, 2026
Closed
ranger-ross
ranger-ross approved these changes Aug 18, 2026
View reviewed changes

@ranger-ross ranger-ross left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

View changes since this review

@ranger-ross
ranger-ross added this pull request to the merge queue Aug 18, 2026
Merged via the queue into rust-lang:master with commit 19112f9 Aug 18, 2026
29 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 18, 2026
@weihanglo weihanglo mentioned this pull request Aug 19, 2026
Merged
rust-bors Bot pushed a commit to rust-lang/rust that referenced this pull request Aug 19, 2026
@bors
Auto merge of #161273 - weihanglo:update-cargo, r=weihanglo
407371f 
Update cargo submodule



6 commits in 8a0d8afba810304bcf9a10bac430be80dd470233..514c56dd7321eecbfdcf9b6479519cf4edfab906
2026-08-15 01:32:53 +0000 to 2026-08-19 00:31:04 +0000
- fix(git): `git gc` with `safe.bareRepository=explicit` (rust-lang/cargo#17370)
- test: make snapshots agnostic to `-Zembed-metadata=no` (rust-lang/cargo#17374)
- fix(clean): Improving description for clean options (rust-lang/cargo#17365)
- Re-stabilize build-dir layout v2 (rust-lang/cargo#17354)
- Enable `-Zembed-metadata=no` by default on nightly Cargo (rust-lang/cargo#17267)
- fix(frontmatter): Don't panic on a short closing fence before a non-ASCII char (rust-lang/cargo#17274)
@rustbot rustbot added this to the 1.100.0 milestone Aug 19, 2026
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Aug 19, 2026
@bors
Auto merge of #161273 - weihanglo:update-cargo, r=weihanglo
f9b5de1 
Update cargo submodule



6 commits in 8a0d8afba810304bcf9a10bac430be80dd470233..514c56dd7321eecbfdcf9b6479519cf4edfab906
2026-08-15 01:32:53 +0000 to 2026-08-19 00:31:04 +0000
- fix(git): `git gc` with `safe.bareRepository=explicit` (rust-lang/cargo#17370)
- test: make snapshots agnostic to `-Zembed-metadata=no` (rust-lang/cargo#17374)
- fix(clean): Improving description for clean options (rust-lang/cargo#17365)
- Re-stabilize build-dir layout v2 (rust-lang/cargo#17354)
- Enable `-Zembed-metadata=no` by default on nightly Cargo (rust-lang/cargo#17267)
- fix(frontmatter): Don't panic on a short closing fence before a non-ASCII char (rust-lang/cargo#17274)
pull Bot pushed a commit to asukaminato0721/rust-analyzer that referenced this pull request Aug 20, 2026
@bors
Auto merge of #161273 - weihanglo:update-cargo, r=weihanglo
0417161 
Update cargo submodule



6 commits in 8a0d8afba810304bcf9a10bac430be80dd470233..514c56dd7321eecbfdcf9b6479519cf4edfab906
2026-08-15 01:32:53 +0000 to 2026-08-19 00:31:04 +0000
- fix(git): `git gc` with `safe.bareRepository=explicit` (rust-lang/cargo#17370)
- test: make snapshots agnostic to `-Zembed-metadata=no` (rust-lang/cargo#17374)
- fix(clean): Improving description for clean options (rust-lang/cargo#17365)
- Re-stabilize build-dir layout v2 (rust-lang/cargo#17354)
- Enable `-Zembed-metadata=no` by default on nightly Cargo (rust-lang/cargo#17267)
- fix(frontmatter): Don't panic on a short closing fence before a non-ASCII char (rust-lang/cargo#17274)
@Suryansh-Dey Suryansh-Dey mentioned this pull request Sep 28, 2026
Closed
@weihanglo weihanglo linked an issue Sep 28, 2026 that may be closed by this pull request
Reword --release arg description for cargo clean to reflect what it does. #17129
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ranger-ross ranger-ross ranger-ross approved these changes

Assignees

@epage epage

Labels

A-cli Area: Command-line interface, option parsing, etc. A-cli-help Area: built-in command-line help A-documenting-cargo-itself Area: Cargo's documentation Command-clean

Projects

None yet

Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

Reword --release arg description for cargo clean to reflect what it does.

4 participants

@Suryansh-Dey @rustbot @ranger-ross @epage