Skip to content

revert(compiler): forward verbose flag to rustc for local crates - #17314

Merged
weihanglo merged 2 commits into
rust-lang:masterfrom
epage:revert
Aug 5, 2026
Merged

revert(compiler): forward verbose flag to rustc for local crates#17314
weihanglo merged 2 commits into
rust-lang:masterfrom
epage:revert

Conversation

@epage

@epage epage commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

What does this PR try to resolve?

This reverts #17006 and will then be beta backported to buy us more time to figure out what should per the Cargo team discussion: https://github.com/rust-lang/cargo-team/blob/main/meetings/sync-meeting/2026-08-04.md#verbose

Fixes #17285

How to test and review this PR?

epage added 2 commits August 5, 2026 10:25
This reverts commit d681940.

Looking to buy us more time since this will be stabilized soon
otherwise.

Closes rust-lang#17285
@epage epage added the beta-nominated Nominated to backport to the beta branch. label Aug 5, 2026
@rustbot rustbot added A-build-execution Area: anything dealing with executing the compiler S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 5, 2026
@rustbot

rustbot commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @epage, @weihanglo
  • @epage, @weihanglo expanded to epage, weihanglo

@weihanglo weihanglo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'll to the submodule updates for beta and nightly once everything is merged.

View changes since this review

@weihanglo
weihanglo enabled auto-merge August 5, 2026 17:42
@weihanglo
weihanglo added this pull request to the merge queue Aug 5, 2026
Merged via the queue into rust-lang:master with commit 2f086a0 Aug 5, 2026
29 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 5, 2026
@epage
epage deleted the revert branch August 5, 2026 19:01
pull Bot pushed a commit to Mattlk13/cargo that referenced this pull request Aug 5, 2026
### What does this PR try to resolve?

This is a follow up to rust-lang#17314.

### How to test and review this PR?
weihanglo added a commit that referenced this pull request Aug 5, 2026
… crates (#17316)

Beta backports

- #17314
- #17315

In order to make CI pass, the following PRs are also cherry-picked:

-
rust-bors Bot pushed a commit to rust-lang/rust that referenced this pull request Aug 8, 2026
Update cargo submodule

14 commits in c79e8f89441b3e73d6d65d125c0c745792808c74..b07e5a08651da80108eb65d7dc769ee04589f9bf
2026-08-04 19:17:33 +0000 to 2026-08-07 21:51:16 +0000
- feat(profile): Add built-in profile debug  (rust-lang/cargo#17214)
- feat(toml): allow overriding inherited default-features in 2024 (rust-lang/cargo#17126)
- feat(resolver): Report the min-publish-age in the lock message (rust-lang/cargo#17328)
- refactor(resolver): resolve() does not need an optional gctx (rust-lang/cargo#17331)
- fix(resolver): Make min-publish-age relative to --publish-time  (rust-lang/cargo#17327)
- test(trim-paths): exercise unremap files with debuggers (rust-lang/cargo#17326)
- feat(log): emit build-started JSON message with run_id  (rust-lang/cargo#16632)
- docs: remove stray `directory` metavar from `cargo update --breaking` option (rust-lang/cargo#17319)
- fix(lock): Use more accurate 'highest, rather than 'latest' (rust-lang/cargo#17317)
- docs(changelog): Pull the --verbose item (rust-lang/cargo#17315)
- revert(compiler): forward verbose flag to rustc for local crates (rust-lang/cargo#17314)
- fix(diag): Gate blanket_hint_mostly_unused with -Zprofile-hint-mostly-unused (rust-lang/cargo#17313)
- fix(diag): Remove complexity, perf, and nursery lint groups (rust-lang/cargo#17307)
- fix(git): Avoid use of git's core.fsmonitor (rust-lang/cargo#17306)

r? ghost
@rustbot rustbot added this to the 1.99.0 milestone Aug 8, 2026
pull Bot pushed a commit to LeeeeeeM/miri that referenced this pull request Aug 9, 2026
Update cargo submodule

14 commits in c79e8f89441b3e73d6d65d125c0c745792808c74..b07e5a08651da80108eb65d7dc769ee04589f9bf
2026-08-04 19:17:33 +0000 to 2026-08-07 21:51:16 +0000
- feat(profile): Add built-in profile debug  (rust-lang/cargo#17214)
- feat(toml): allow overriding inherited default-features in 2024 (rust-lang/cargo#17126)
- feat(resolver): Report the min-publish-age in the lock message (rust-lang/cargo#17328)
- refactor(resolver): resolve() does not need an optional gctx (rust-lang/cargo#17331)
- fix(resolver): Make min-publish-age relative to --publish-time  (rust-lang/cargo#17327)
- test(trim-paths): exercise unremap files with debuggers (rust-lang/cargo#17326)
- feat(log): emit build-started JSON message with run_id  (rust-lang/cargo#16632)
- docs: remove stray `directory` metavar from `cargo update --breaking` option (rust-lang/cargo#17319)
- fix(lock): Use more accurate 'highest, rather than 'latest' (rust-lang/cargo#17317)
- docs(changelog): Pull the --verbose item (rust-lang/cargo#17315)
- revert(compiler): forward verbose flag to rustc for local crates (rust-lang/cargo#17314)
- fix(diag): Gate blanket_hint_mostly_unused with -Zprofile-hint-mostly-unused (rust-lang/cargo#17313)
- fix(diag): Remove complexity, perf, and nursery lint groups (rust-lang/cargo#17307)
- fix(git): Avoid use of git's core.fsmonitor (rust-lang/cargo#17306)

r? ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-build-execution Area: anything dealing with executing the compiler beta-nominated Nominated to backport to the beta branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conflict between CARGO_TERM_VERBOSE=true and RUSTFLAGS=--verbose

3 participants