add ICON from crates.io to the cargo executable on windows

[ShadowDara]

Thanks for the pull request 🎉!
Please read the contribution guide: https://doc.crates.io/contrib/.

What does this PR try to resolve?

The Change add a software icon to the cargo executable on windows

How to test and review this PR?

The Code changes the standard Icon from windows to the Icon from crates.io

[rustbot]

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[weihanglo]

Thanks for the code contribution.

Per our contributing guide, we encourage to discuss first before jumping straight to a pull request.

If you're willing to, please open a new issue for discussions. I'll mark this as draft for now.

[ShadowDara]

Okay i am sorry, i though this just a little change so ... I'm sorry

[ShadowDara]

Issue as Feature Request or Inspiring Idea? I'll Inspiring Idea for now, because its not really a Feature

[ShadowDara]

For Anyone Reading this, here: https://internals.rust-lang.org/t/add-icon-from-crates-io-to-the-cargo-executable-on-windows/23597

[joshtriplett]

Some preliminary feedback (leaving aside for the moment the question of whether we want to do this): this should be conditional on the target being windows, not the build architecture being windows, so that you get the icon even when cross-compiling to windows. Look at windows_manifest() for the way the conditionals are structured.

[mathstuf]

Additionally, what is the license of the icon? (I know I can follow the link in the code, but I feel like it needs to be more explicit here.)

[CodesInChaos]

winres appears to be unmaintained and have known bugs. It also adds a second version of the toml crate. Perhaps the winresource fork would be a better choice?

Or perhaps a pre-built res-file to avoid this dependency (and the dependency on rc.exe)?

[ShadowDara]

Oh i'm sorry thats a lot of stuff i didn't knew about before

[Aloso]

Additionally, what is the license of the icon?

CC-BY. See the trademark policy.

It's best to ask the Rust Foundation for permission, but I don't see a reason why they would be against it.

[rustbot]

☔ The latest upstream changes (possibly #16137) made this pull request unmergeable. Please resolve the merge conflicts.