Repository navigation
Conversation
Clarify usage of default-members with root package in workspaces.
Collaborator
weihanglo
reviewed
Sep 4, 2025
| > you can only operate on it using `--package` and `--workspace` flags. | ||
| > Note: If `default-members` is specified and a [root package](#root-package) is present, | ||
| > you can only operate on the root package using `--package` and `--workspace` flags. | ||
| > There is no way to specify the root package explicitly in the `default-members` field. |
Member
There was a problem hiding this comment.
Actually you can do that through default-members = ["."].
Maybe we should remove this instead?
Contributor
|
@rustbot author |
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
Collaborator
|
☔ The latest upstream changes (possibly #17230) made this pull request unmergeable. Please resolve the merge conflicts. |
Author
|
I'm just going to close this since clearly nobody cares. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify usage of default-members with root package in workspaces.
What does this PR try to resolve?
I found this section of the doc confusing. I have made clarifications that align with my understanding. If this understanding is incorrect, then presumably a different change would be in order.
How to test and review this PR?
Doc change only