refactor: log when loading config from file#12991
Merged
Merged
Conversation
Collaborator
|
r? @ehuss (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-configuration
epage
reviewed
Nov 16, 2023
epage
approved these changes
Nov 16, 2023
epage
left a comment
epage
left a comment
Contributor
There was a problem hiding this comment.
Feel free to r= me whichever way you go
weihanglo
force-pushed
the
tracing-config-load
branch
from
39f0b8c to
1e58b10
Compare
Member
Author
|
@bors r+ Thanks for the review! |
Contributor
bors
added
S-waiting-on-bors
Member
Author
|
@bors r- |
bors
added
S-waiting-on-author
Member
Author
|
@bors r=epage |
Contributor
bors
added
S-waiting-on-bors
Contributor
bors
added a commit
that referenced
this pull request
Nov 16, 2023
refactor: log when loading config from file When I was tracing some nasty bug and wanted to point at config probding, I wish there were some logs standing out and telling me I was wrong. Would be great if every config file loading is logged.
Contributor
Contributor
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 18, 2023
Update cargo 11 commits in 2c03e0e2dcd05dd064fcf10cc1050d342eaf67e3..9765a449d9b7341c2b49b88da41c2268ea599720 2023-11-16 04:21:44 +0000 to 2023-11-17 20:58:23 +0000 - refactor(toml): Clean up workspace inheritance (rust-lang/cargo#12971) - docs: Recommend a wider selection of libsecret-compatible password managers (rust-lang/cargo#12993) - feat(cli): add color output for `cargo --list` (rust-lang/cargo#12992) - refactor: log when loading config from file (rust-lang/cargo#12991) - Link to rustc lint levels (rust-lang/cargo#12990) - chore(ci): Catch naive use of AtomicU64 early (rust-lang/cargo#12988) - cargo-credential-1password: Add missing `--account` argument to `op signin` command (rust-lang/cargo#12985) - chore: dogfood Cargo `-Zlints` table feature (rust-lang/cargo#12178) - cargo-credential-1password: Fix README (rust-lang/cargo#12986) - Fix a rustflags test using a wrong buildfile name (rust-lang/cargo#12987) - Fix some test output validation. (rust-lang/cargo#12982) r? ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I was tracing some nasty bug and wanted to point at config probding, I wish there were some logs standing out and telling me I was wrong.
Would be great if every config file loading is logged.