-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
cargo package should warn binary files by default #4413
Copy link
Copy link
Open
Labels
A-new-lintArea: new lintArea: new lintC-enhancementCategory: enhancementCategory: enhancementCommand-packageS-needs-designStatus: Needs someone to work further on the design for the feature or fix. NOT YET accepted.Status: Needs someone to work further on the design for the feature or fix. NOT YET accepted.
Metadata
Metadata
Assignees
Labels
A-new-lintArea: new lintArea: new lintC-enhancementCategory: enhancementCategory: enhancementCommand-packageS-needs-designStatus: Needs someone to work further on the design for the feature or fix. NOT YET accepted.Status: Needs someone to work further on the design for the feature or fix. NOT YET accepted.
Type
Fields
Give feedbackNo fields configured for issues without a type.
I've seen multiple times that some images which is used in README only is included into crate package, e.g. bindgen contains a 1.3MB PNG, and dtoa contains a 68KB PNG.
I believe binary files in general are not useful in packages. They should be excluded or at least warned by default. People should still be able to explicitly specify binary files if necessary, though.