Skip to content

add MSRV 1.88.0 to Cargo.toml, determined with "cargo msrv find"#33

Merged
bjorn3 merged 2 commits into
rust-lang:mainfrom
ilka-schulz:add-msrv
Jun 9, 2026
Merged

add MSRV 1.88.0 to Cargo.toml, determined with "cargo msrv find"#33
bjorn3 merged 2 commits into
rust-lang:mainfrom
ilka-schulz:add-msrv

Conversation

@ilka-schulz

@ilka-schulz ilka-schulz commented Jun 8, 2026

Copy link
Copy Markdown

This PR fixes compile errors downstream for projects supporting older MSRV than ar_archive_writer. What I did:

Output of `cargo msrv find`
$ cargo msrv find
  [Meta]   cargo-msrv 0.19.3  

Compatibility Check #1: Rust 1.91.1
  [OK]     Is compatible 

Compatibility Check #2: Rust 1.88.0
  [OK]     Is compatible 

Compatibility Check #3: Rust 1.86.0
  [FAIL]   Is incompatible 
                                                                                                        
  ╭────────────────────────────────────────────────────────────────────────────────────────────────────╮
  │     Checking ar_archive_writer v0.5.1 (/home/user/ar_archive_writer)                               │
  │ error[E0658]: `let` expressions in this position are unstable                                      │
  │    --> src/archive_writer.rs:591:20                                                                │
  │     |                                                                                              │
  │ 591 |                 if let Some(ec_map) = &mut ec_map                                            │
  │     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                            │
  │     |                                                                                              │
  │     = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information │
  │                                                                                                    │
  │ error[E0658]: `let` expressions in this position are unstable                                      │
  │    --> src/coff_import_file.rs:141:12                                                              │
  │     |                                                                                              │
  │ 141 |         if let Some((first_char, rest)) = name.split_at_checked(1)                           │
  │     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                           │
  │     |                                                                                              │
  │     = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information │
  │                                                                                                    │
  │ For more information about this error, try `rustc --explain E0658`.                                │
  │ error: could not compile `ar_archive_writer` (lib) due to 2 previous errors                        │
  │                                                                                                    │
  ╰────────────────────────────────────────────────────────────────────────────────────────────────────╯
                                                                                                        

Compatibility Check #4: Rust 1.87.0
  [FAIL]   Is incompatible 
                                                                                                        
  ╭────────────────────────────────────────────────────────────────────────────────────────────────────╮
  │     Checking ar_archive_writer v0.5.1 (/home/user/ar_archive_writer)                               │
  │ error[E0658]: `let` expressions in this position are unstable                                      │
  │    --> src/archive_writer.rs:591:20                                                                │
  │     |                                                                                              │
  │ 591 |                 if let Some(ec_map) = &mut ec_map                                            │
  │     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                            │
  │     |                                                                                              │
  │     = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information │
  │                                                                                                    │
  │ error[E0658]: `let` expressions in this position are unstable                                      │
  │    --> src/coff_import_file.rs:141:12                                                              │
  │     |                                                                                              │
  │ 141 |         if let Some((first_char, rest)) = name.split_at_checked(1)                           │
  │     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                           │
  │     |                                                                                              │
  │     = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information │
  │                                                                                                    │
  │ For more information about this error, try `rustc --explain E0658`.                                │
  │ error: could not compile `ar_archive_writer` (lib) due to 2 previous errors                        │
  │                                                                                                    │
  ╰────────────────────────────────────────────────────────────────────────────────────────────────────╯
                                                                                                        

Result:
   Considered (min … max):   Rust 1.85.1 … Rust 1.96.0 
   Search method:            bisect                    
   MSRV:                     1.88.0                    
   Target:                   x86_64-unknown-linux-gnu  
                                                       

To Do

cargo test fails:

thread 'compare_to_lib' (553353) panicked at tests/import_library.rs:193:9:
assertion failed: `(left == right)`: Import library differs. Machine type: I386

However, this has already been failing on main.

@ilka-schulz ilka-schulz marked this pull request as ready for review June 8, 2026 10:44
@ilka-schulz ilka-schulz marked this pull request as draft June 8, 2026 10:45
@ilka-schulz ilka-schulz marked this pull request as ready for review June 8, 2026 11:01
ilka-schulz pushed a commit to rosenpass/rosenpass that referenced this pull request Jun 8, 2026
$ cargo tree --workspace -i ar_archive_writer
ar_archive_writer v0.5.1
[build-dependencies]
└── psm v0.1.31
    └── stacker v0.1.24
        └── rosenpass-fuzzing v0.0.1 (/home/user/rosenpass/fuzz)
        [dev-dependencies]
        ├── rosenpass v0.3.0-dev (/home/user/rosenpass/rosenpass)
        │   ├── rosenpass-fuzzing v0.0.1 (/home/user/rosenpass/fuzz)
        │   └── rosenpass-rp v0.2.1 (/home/user/rosenpass/rp)
        └── rosenpass-rp v0.2.1 (/home/user/rosenpass/rp)
ilka-schulz pushed a commit to rosenpass/rosenpass that referenced this pull request Jun 8, 2026
$ cargo tree --workspace -i ar_archive_writer
ar_archive_writer v0.5.1
[build-dependencies]
└── psm v0.1.31
    └── stacker v0.1.24
        └── rosenpass-fuzzing v0.0.1 (/home/user/rosenpass/fuzz)
        [dev-dependencies]
        ├── rosenpass v0.3.0-dev (/home/user/rosenpass/rosenpass)
        │   ├── rosenpass-fuzzing v0.0.1 (/home/user/rosenpass/fuzz)
        │   └── rosenpass-rp v0.2.1 (/home/user/rosenpass/rp)
        └── rosenpass-rp v0.2.1 (/home/user/rosenpass/rp)
ilka-schulz pushed a commit to rosenpass/rosenpass that referenced this pull request Jun 8, 2026
$ cargo tree --workspace -i ar_archive_writer
ar_archive_writer v0.5.1
[build-dependencies]
└── psm v0.1.31
    └── stacker v0.1.24
        └── rosenpass-fuzzing v0.0.1 (/home/user/rosenpass/fuzz)
        [dev-dependencies]
        ├── rosenpass v0.3.0-dev (/home/user/rosenpass/rosenpass)
        │   ├── rosenpass-fuzzing v0.0.1 (/home/user/rosenpass/fuzz)
        │   └── rosenpass-rp v0.2.1 (/home/user/rosenpass/rp)
        └── rosenpass-rp v0.2.1 (/home/user/rosenpass/rp)
@bjorn3 bjorn3 merged commit 1e137ce into rust-lang:main Jun 9, 2026
1 of 2 checks passed
@bjorn3

bjorn3 commented Jun 9, 2026

Copy link
Copy Markdown
Member

Published as v0.5.2.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 9, 2026
…=jieyouxu

Update to ar_archive_writer v0.5.2

This includes rust-lang/ar_archive_writer#32 and rust-lang/ar_archive_writer#33. The former fixes a panic when there are more than 64k archive members.
@ilka-schulz

Copy link
Copy Markdown
Author

Thank you @bjorn3! ❤️

jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 9, 2026
…=jieyouxu

Update to ar_archive_writer v0.5.2

This includes rust-lang/ar_archive_writer#32 and rust-lang/ar_archive_writer#33. The former fixes a panic when there are more than 64k archive members.
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 9, 2026
…=jieyouxu

Update to ar_archive_writer v0.5.2

This includes rust-lang/ar_archive_writer#32 and rust-lang/ar_archive_writer#33. The former fixes a panic when there are more than 64k archive members.
pull Bot pushed a commit to Kokoro2336/rust-analyzer that referenced this pull request Jun 11, 2026
Update to ar_archive_writer v0.5.2

This includes rust-lang/ar_archive_writer#32 and rust-lang/ar_archive_writer#33. The former fixes a panic when there are more than 64k archive members.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants