add MSRV 1.88.0 to Cargo.toml, determined with "cargo msrv find"#33
Merged
Conversation
ilka-schulz
pushed a commit
to rosenpass/rosenpass
that referenced
this pull request
Jun 8, 2026
$ cargo tree --workspace -i ar_archive_writer
ar_archive_writer v0.5.1
[build-dependencies]
└── psm v0.1.31
└── stacker v0.1.24
└── rosenpass-fuzzing v0.0.1 (/home/user/rosenpass/fuzz)
[dev-dependencies]
├── rosenpass v0.3.0-dev (/home/user/rosenpass/rosenpass)
│ ├── rosenpass-fuzzing v0.0.1 (/home/user/rosenpass/fuzz)
│ └── rosenpass-rp v0.2.1 (/home/user/rosenpass/rp)
└── rosenpass-rp v0.2.1 (/home/user/rosenpass/rp)
ilka-schulz
pushed a commit
to rosenpass/rosenpass
that referenced
this pull request
Jun 8, 2026
$ cargo tree --workspace -i ar_archive_writer
ar_archive_writer v0.5.1
[build-dependencies]
└── psm v0.1.31
└── stacker v0.1.24
└── rosenpass-fuzzing v0.0.1 (/home/user/rosenpass/fuzz)
[dev-dependencies]
├── rosenpass v0.3.0-dev (/home/user/rosenpass/rosenpass)
│ ├── rosenpass-fuzzing v0.0.1 (/home/user/rosenpass/fuzz)
│ └── rosenpass-rp v0.2.1 (/home/user/rosenpass/rp)
└── rosenpass-rp v0.2.1 (/home/user/rosenpass/rp)
ilka-schulz
pushed a commit
to rosenpass/rosenpass
that referenced
this pull request
Jun 8, 2026
$ cargo tree --workspace -i ar_archive_writer
ar_archive_writer v0.5.1
[build-dependencies]
└── psm v0.1.31
└── stacker v0.1.24
└── rosenpass-fuzzing v0.0.1 (/home/user/rosenpass/fuzz)
[dev-dependencies]
├── rosenpass v0.3.0-dev (/home/user/rosenpass/rosenpass)
│ ├── rosenpass-fuzzing v0.0.1 (/home/user/rosenpass/fuzz)
│ └── rosenpass-rp v0.2.1 (/home/user/rosenpass/rp)
└── rosenpass-rp v0.2.1 (/home/user/rosenpass/rp)
bjorn3
approved these changes
Jun 9, 2026
This was referenced Jun 9, 2026
Member
|
Published as v0.5.2. |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jun 9, 2026
…=jieyouxu Update to ar_archive_writer v0.5.2 This includes rust-lang/ar_archive_writer#32 and rust-lang/ar_archive_writer#33. The former fixes a panic when there are more than 64k archive members.
Author
|
Thank you @bjorn3! ❤️ |
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jun 9, 2026
…=jieyouxu Update to ar_archive_writer v0.5.2 This includes rust-lang/ar_archive_writer#32 and rust-lang/ar_archive_writer#33. The former fixes a panic when there are more than 64k archive members.
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jun 9, 2026
…=jieyouxu Update to ar_archive_writer v0.5.2 This includes rust-lang/ar_archive_writer#32 and rust-lang/ar_archive_writer#33. The former fixes a panic when there are more than 64k archive members.
pull Bot
pushed a commit
to Kokoro2336/rust-analyzer
that referenced
this pull request
Jun 11, 2026
Update to ar_archive_writer v0.5.2 This includes rust-lang/ar_archive_writer#32 and rust-lang/ar_archive_writer#33. The former fixes a panic when there are more than 64k archive members.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes compile errors downstream for projects supporting older MSRV than
ar_archive_writer. What I did:rust-versionkey toCargo.tomlis_multiple_of– https://rust-lang.github.io/rust-clippy/rust-1.96.0/index.html#manual_is_multiple_ofOutput of `cargo msrv find`
To Do
cargo testfails:However, this has already been failing on
main.