Skip to content

impl: parse_and_output_manpages#96

Merged
pickfire merged 47 commits intorust-dc:masterfrom
charliethomson:parse_and_output_manpages_fixed
Aug 1, 2020
Merged

impl: parse_and_output_manpages#96
pickfire merged 47 commits intorust-dc:masterfrom
charliethomson:parse_and_output_manpages_fixed

Conversation

@charliethomson
Copy link
Copy Markdown
Contributor

@charliethomson charliethomson commented Jul 13, 2020

No description provided.

scooter-dangle
scooter-dangle reviewed Jul 13, 2020
View reviewed changes
Comment thread Cargo.toml Outdated
scooter-dangle
scooter-dangle reviewed Jul 13, 2020
View reviewed changes
Comment thread Cargo.toml Outdated
pickfire
pickfire reviewed Jul 13, 2020
View reviewed changes
Comment thread src/main.rs Outdated
pickfire
pickfire reviewed Jul 13, 2020
View reviewed changes
Comment thread src/main.rs Outdated
pickfire
pickfire reviewed Jul 13, 2020
View reviewed changes
Comment thread src/main.rs Outdated
pickfire
pickfire reviewed Jul 13, 2020
View reviewed changes
Comment thread src/main.rs Outdated
pickfire
pickfire reviewed Jul 13, 2020
View reviewed changes
Comment thread src/main.rs Outdated
pickfire
pickfire reviewed Jul 13, 2020
View reviewed changes
Comment thread src/main.rs Outdated
pickfire
pickfire reviewed Jul 13, 2020
View reviewed changes
Comment thread src/main.rs Outdated
pickfire
pickfire reviewed Jul 13, 2020
View reviewed changes
Comment thread src/main.rs
pickfire
pickfire reviewed Jul 13, 2020
View reviewed changes
Comment thread src/main.rs Outdated
pickfire
pickfire reviewed Jul 13, 2020
View reviewed changes
Comment thread src/main.rs
pickfire
pickfire reviewed Jul 13, 2020
View reviewed changes
Comment thread src/main.rs Outdated
pickfire
pickfire reviewed Jul 13, 2020
View reviewed changes
Comment thread src/main.rs Outdated
pickfire
pickfire reviewed Jul 13, 2020
View reviewed changes
Comment thread src/main.rs Outdated
pickfire
pickfire reviewed Jul 14, 2020
View reviewed changes
Comment thread src/main.rs Outdated
pickfire
pickfire reviewed Jul 14, 2020
View reviewed changes
Comment thread src/main.rs Outdated
scooter-dangle
scooter-dangle reviewed Jul 21, 2020
View reviewed changes
Comment thread src/main.rs Outdated
scooter-dangle
scooter-dangle reviewed Jul 21, 2020
View reviewed changes
Comment thread src/main.rs Outdated
scooter-dangle
scooter-dangle reviewed Jul 21, 2020
View reviewed changes
Comment thread src/main.rs Outdated
pickfire
pickfire reviewed Jul 21, 2020
View reviewed changes
Comment thread src/main.rs Outdated
pickfire
pickfire reviewed Jul 21, 2020
View reviewed changes
Comment thread src/main.rs Outdated
pickfire
pickfire reviewed Jul 23, 2020
View reviewed changes
Comment thread src/main.rs Outdated
pickfire
pickfire reviewed Jul 23, 2020
View reviewed changes
Comment thread src/main.rs Outdated
pickfire
pickfire reviewed Jul 23, 2020
View reviewed changes
Comment thread src/main.rs Outdated
pickfire
pickfire reviewed Jul 23, 2020
View reviewed changes
Comment thread src/main.rs Outdated
pickfire
pickfire reviewed Jul 23, 2020
View reviewed changes
Comment thread src/main.rs Outdated
charliethomson and others added 6 commits July 24, 2020 16:16
@charliethomson @pickfire
Remove one line of whitespace
4f22c2c 
Co-authored-by: Ivan Tham <pickfire@riseup.net>
@charliethomson @pickfire
as_ref()
8ae866d 
Co-authored-by: Ivan Tham <pickfire@riseup.net>
@charliethomson @pickfire
as_ref() part 2
c72ad4d 
Co-authored-by: Ivan Tham <pickfire@riseup.net>
@charliethomson
deas_ref, max_digits, remove initial spaces from
59d309a
@charliethomson
remove last_len, padding; use progress instead
69bca77
@charliethomson
Use display
5cae975
pickfire
pickfire reviewed Jul 26, 2020
View reviewed changes
Comment thread src/main.rs
@charliethomson @pickfire
panic! one line
40df153 
Co-authored-by: Ivan Tham <pickfire@riseup.net>
pickfire
pickfire approved these changes Aug 1, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@pickfire
Copy link
Copy Markdown
Collaborator

pickfire commented Aug 1, 2020

@charliethomson You are correct, the panic I suggested was incorrect, I didn't test it correct. Sorry about the bad suggestion, can you please revert it? Once it is reverted I can merge this.

@charliethomson
Copy link
Copy Markdown
Contributor Author

charliethomson commented Aug 1, 2020

@pickfire

@pickfire pickfire merged commit 9e57acf into rust-dc:master Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pickfire pickfire pickfire approved these changes

@scooter-dangle scooter-dangle Awaiting requested review from scooter-dangle

+1 more reviewer

@Lonami Lonami Lonami left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@charliethomson @pickfire @scooter-dangle @Lonami