fix(fmt): Improve terminal styling support#298
Merged
epage merged 13 commits intorust-cli:mainfrom Jan 19, 2024
Merged
Conversation
- 1.70.0 is needed for `anstream` to be added - 1.71.0 is needed for changes to how cargo treats features
This also adds support for `NO_COLOR` and `CLICOLOR_FORCE`, see https://bixense.com/clicolors/
This was discussed in rust-cli#225 but no dedicated issue for it.
This was referenced Jan 18, 2024
epage
force-pushed
the
term
branch
2 times, most recently
from
2dc048f to
ea46409
Compare
epage
added a commit
to epage/env_logger
that referenced
this pull request
Feb 13, 2024
The documentation for the old API was overlooked in rust-cli#298
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches the backend to
anstreamclap, this saves on the number of dependenciesCLICOLOR_FORCEandNO_COLORare respectedPipe(WriteStyleis ignored when used withTarget::Pipe#274)This comes with an MSRV bump to 1.70. This allows us to use the latest
anstreamand avoidis-terminal.BREAKING CHANGE:
Formatter::style,Formatter::default_styled_level,Color,Style, andStyledValuewere removed.Formatter::default_level_stylewas changed to returnanstyle::Style.Fixes #274
Fixes #276