Add FilteredLog utility to combine a Filter with a Log.#295
Closed
de-vri-es wants to merge 2 commits intorust-cli:mainfrom
Closed
Add FilteredLog utility to combine a Filter with a Log.#295de-vri-es wants to merge 2 commits intorust-cli:mainfrom
FilteredLog utility to combine a Filter with a Log.#295de-vri-es wants to merge 2 commits intorust-cli:mainfrom
Conversation
46af979 to
ca9f903
Compare
Contributor
|
#193 is the issue for this. I lean towards the crate-splitting route, over publically exposing these details within this crate. |
Author
|
The So.. if I make a PR to split And then would you be inclined to accept this utility to wrap an existing logger? |
This can be used by end-users that want to combine the filtering capabilities of `env_logger` with a different `Log` implementation.
ca9f903 to
39e267f
Compare
Author
|
Pushed a commit to split the Or do you think it would be better to move it to a separate git repo? |
This was referenced Jan 19, 2024
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can be used by end-users that want to combine the filtering capabilities of
env_loggerwith a differentLogimplementation.In my case, I want to combine the filtering of
env_loggerwithsystemd-journal-logger. I could just do it myself where I need it, but this feels like something that could be useful to provide fromenv_loggeralready.