feat: dynamic path resolution for lima config during vm init#1768
Open
ayush-panta wants to merge 2 commits into
Open
feat: dynamic path resolution for lima config during vm init#1768ayush-panta wants to merge 2 commits into
ayush-panta wants to merge 2 commits into
Conversation
Signed-off-by: ayush-panta <ayushkp@amazon.com>
At vm init time, detect the baked-in install root from the base YAML template and replace it with the actual install location. The resolved copy is written to os/base.yaml, leaving the shipped template unchanged. This allows the same binary to work from any install path. Signed-off-by: ayush-panta <ayushkp@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes: At build time, absolute paths (e.g.,
/Applications/Finch/os/...) are baked into the Lima base YAML template. This means the binary only works when installed at that exact path.This PR resolves paths at runtime during
finch vm init. It reads the shipped template, detects the baked-in root, replaces it with the actual install location, and writes a resolved copy tolima/data/_config/base.yaml. Lima reads that instead of the original template. The shipped artifact is never modified.This enables finch to run from any install location without a separate build.
Testing done: Added unit tests and verified rewrite behavior. Here is an example moving to userspace:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.