Open
Conversation
|
When will this be merged? I'm using @kou rabbit plugin for presentations and it would be nice to use backticks for highlightning code. I think that I'm not the only person waiting for this. |
Conflicts: lib/coderay/helpers/file_type.rb
Member
Author
|
It cannot be merged because it's broken. It's not my code, it was a contribution. As always, we need test code examples. Currently, when I run the tests: |
|
Hi @korny is there a way that we can pair on a remote session with vim and tmux to fix that problem? When I run the tests of the original repo on my machine with Cloning into 'test/scanners'...
remote: Reusing existing pack: 1037, done.
remote: Total 1037 (delta 0), reused 0 (delta 0)
Receiving objects: 100% (1037/1037), 10.59 MiB | 888.00 KiB/s, done.
Resolving deltas: 100% (483/483), done.
Checking connectivity... done
/home/wikimatze/.rubies/ruby-2.1.0/bin/ruby test/scanners/suite.rb
Loaded suite CodeRay::Scanners
Started
>> Skipping tests for bash, no scanner found <<
.
>> Testing C scanner <<
Random test - finished.
Loading examples in test/scanners/c/*.in.c...7 examples found.
elvis 370 B incremental, shuffled, complete, identity, highlighting, too small.
empty 0 B incremental, -skipped- complete, identity, highlighting, too small.
error 4 B incremental, -skipped- complete, identity, highlighting, too small.
error2 3 B incremental, -skipped- complete, identity, highlighting, too small.
open-string 1 B incremental, -skipped- complete, identity, highlighting, too small.
ruby 2.2 MiB incremental, shuffled, complete, identity, highlighting, in kTok/s: 761 scan + 473 encode = 292 both, 364 stream, in kB/s: 2779 / 1330.
strange 3.7 KiB incremental, shuffled, complete, identity, highlighting, in kTok/s: 559 scan + 252 encode = 174 both, 203 stream, in kB/s: 3049 / 1104.
Average speed for C scanner: 2779 kB/s scanning / 1330 kB/s highlighting to HTML page.
Finished in 8.48s.So you are trying to implement the bash scanner, right? Kindly regards Matthias |
This was referenced Oct 7, 2014
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress. Lacks tests. Solves #19, might be related to #115.