Fix BasicObject#instance_eval signature#39
Merged
soutaro merged 2 commits intoruby:masterfrom Oct 27, 2019
Merged
Conversation
Contributor
hanachin
commented
Oct 24, 2019
Member
|
I will check what is happening... |
Member
|
Okay, it is because |
Merged
0e4aa52 to
6d3864a
Compare
```
irb(main):001:0> 42.instance_eval { p _1 }
42
=> 42
irb(main):002:-> 42.instance_eval(&->{})
Traceback (most recent call last):
6: from /usr/local/var/rbenv/versions/master/bin/irb:23:in `<main>'
5: from /usr/local/var/rbenv/versions/master/bin/irb:23:in `load'
4: from /usr/local/var/rbenv/versions/master/lib/ruby/gems/2.7.0/gems/irb-1.1.0.pre.3/exe/irb:11:in `<top (required)>'
3: from (irb):2
2: from (irb):2:in `instance_eval'
1: from (irb):2:in `block in irb_binding'
ArgumentError (wrong number of arguments (given 1, expected 0))
```
6d3864a to
3fe474d
Compare
Contributor
Author
|
#41 made BasicObject testable 👏 so I added a test ✌️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.