Conversation
7 tasks
a4c3899 to
4b56eef
Compare
Collaborator
|
Thanks @exterm! Would you mind adding it to |
kddnewton
requested changes
Feb 14, 2024
Collaborator
kddnewton
left a comment
There was a problem hiding this comment.
Just marking as "request changes"
4b56eef to
9ad7968
Compare
Contributor
Author
|
Done and I also added |
9ad7968 to
f09ace2
Compare
eregon
reviewed
Feb 16, 2024
|
|
||
| Benchmark.ips do |x| | ||
| x.report("Parser::CurrentRuby") { Parser::CurrentRuby.parse_file(filepath) } | ||
| x.report("Parser::Prism") { Prism.parse_file(filepath) } |
Member
There was a problem hiding this comment.
This should be labeled just Prism as there is no Parser::Prism (it confused me for the results in the PR description).
I was about to make a PR but @kddnewton already fixed it in 40059d3 :)
Contributor
Author
There was a problem hiding this comment.
Ah dang, that's copy-pasta. Thanks for the note, Benoit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to what @kddnewton did in parser-prism.
I needed an easy way to compare performance of the different parser options. I think it would make sense for it to live in this repo for now.
These are the results from a run on my local machine:
Prism 0.23.0
Prism 0.24.0