Update truffleruby workflow now that Prism is default#2358
Merged
Conversation
* Because installing JVMCI now needs to have graal cloned or clones it.
kddnewton
approved these changes
Feb 3, 2024
headius
added a commit
to headius/stringio
that referenced
this pull request
Mar 13, 2024
All of these operations are leaves, so no reentrancy is necessary. None of them make any blocking calls, either, so they should return very quickly. And use of StringIO under concurrent load is very unusual and unlikely to lead to contention. This patch switches from using hard JVM synchronization to instead just spin- lock on an atomic int value associated with the data ptr object. Performance on a benchmark of the Prism parser from ruby/prism#2358 shows a reduction per loop from 0.050s to 0.044s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test run at https://github.com/ruby/prism/actions/runs/7766621135/job/21182640278