Skip to content

Add XOAUTH2 authenticator#63

Merged
shugo merged 3 commits into
ruby:masterfrom
ssunday:add-xoauth2-authenticator
Sep 29, 2022
Merged

Add XOAUTH2 authenticator#63
shugo merged 3 commits into
ruby:masterfrom
ssunday:add-xoauth2-authenticator

Conversation

@ssunday

@ssunday ssunday commented Sep 22, 2022

Copy link
Copy Markdown
Contributor

Thanks to https://github.com/nfo/gmail_xoauth for doing the heavy lifting and changing the license. 💪🏻

I tested it with a Microsoft 365 account. I would appreciate someone verifying it works with Gmail too to make sure.

Let me know if there's anything else that I can do to get this in 🙏🏻

@ssunday

ssunday commented Sep 22, 2022

Copy link
Copy Markdown
Contributor Author

Part of #12

@ssunday ssunday changed the title Add XOAuth2 authenticator Add XOauth2 authenticator Sep 22, 2022
@ssunday ssunday changed the title Add XOauth2 authenticator Add XOAUTH2 authenticator Sep 22, 2022
@hsbt

hsbt commented Sep 28, 2022

Copy link
Copy Markdown
Member

@ssunday Can you rebase from the current master?

Comment thread lib/net/imap/authenticators/xoauth2.rb Outdated
@ssunday

ssunday commented Sep 28, 2022

Copy link
Copy Markdown
Contributor Author

@hsbt rebased

@ssunday ssunday requested a review from shugo September 29, 2022 00:12

@shugo shugo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine. Thank you!

@shugo shugo merged commit a0d6724 into ruby:master Sep 29, 2022
@ssunday ssunday deleted the add-xoauth2-authenticator branch September 29, 2022 12:40
@nevans

nevans commented Sep 29, 2022

Copy link
Copy Markdown
Collaborator

thanks! I'd started on this a while ago and got completely sidetracked. thanks again!

Additionally, thanks for the reminder that I'd forgotten about it. No promises, but I'll try to finish up my ANONYMOUS, EXTERNAL, OAUTHBEARER, and SCRAM-* PRs this week.

@Neustradamus

Copy link
Copy Markdown

@ssunday: Thanks for your PR!

@nevans: Can not wait ^^

@nevans nevans added the SASL 🔒 Authentication and authentication mechanisms label Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

SASL 🔒 Authentication and authentication mechanisms

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants