Add config option to skip confirmation on quit#525
Add config option to skip confirmation on quit#525hugovandevliert wants to merge 2 commits intoruby:masterfrom
Conversation
| def test_quit_quits_immediately_if_no_confirm_quit_is_set_to_true | ||
| debug_code(program) do | ||
| type 'config set no_confirm_quit true' | ||
| type 'q' | ||
| end | ||
| end |
There was a problem hiding this comment.
This spec doesn't pass. I suspect it's because of test/tool/test_builder.rb:121, but I'm not sure. If the maintainers are interested in this PR I'll happily spend some time trying to make this spec pass.
|
@hugovandevliert As an ex-pry guy, I get the motivation of this proposal. It also bothered me a while for adjusting to the new commands. |
Fair enough. The only fact that's keeping me from using this debugger full-time is the fact that we're still using Thanks for your time. |
|
@hugovandevliert Haha no problem. Convincing developers to switch debugging tools is hard. FWIW, I personal favorites are:
And more features like TUI support is also on the way: #503 |
|
TUI support looks amazing. Will definitely keep an eye out for that. Thanks for the examples :-) |
|
Can we close it? Like |
Description
Hi there! I took the liberty to implement a feature that I would love to see added.
In short: this PR adds a config option that disables the 'Really quit?' prompt after hitting
CRTL+Dorq[uit].To give some context:
I have been using
pryfor a long time. Currently, I'm usingdebugfor my personal projects, but professionally we haven't made the switch (yet). Meaning I often switch between the two.I'm used to stopping debugging sessions by hitting
CTRL+D, which instantly closespry. Indebughowever, this gives the 'Really quit?' prompt, which requires ayand↵.There is already
q!which quits instantly, so this PR might be redundant. However, I find myself often forgetting about it and getting slightly frustrated during debugging sessions :).This PR allows me to simply put
config set no_confirm_quit truein my~/.rdbgrcand never worry about remembering to use the slightly awkwardq!sequence again.