Fix incorrect argc2 decrement in datetime_s_iso8601 function

[pelbyl]

Replace the decrement (argc2--) with an increment (argc2++) for the correct number of arguments when opt is provided.

[jeremyevans]

Is it possible for you to include a test?

[jeremyevans]

Since you asked via email what I meant by "include a test"?, it would be updating the test code to show that your change fixes the issue. I believe it does, as it appears use of limit keyword is currently broken for the method. You'd probably want to add a test case near

date/test/date/test_date_strftime.rb

Line 386 in c2d9cc2

assert_equal('2001-02-03T04:05:06.123+00:00', d2.iso8601(3))

[pelbyl]

Got it, thank you.Sent from my iPhoneOn 23 Sep 2024, at 01:05, Jeremy Evans ***@***.***> wrote: Since you asked via email what I meant by "include a test"?, it would be updating the test code to show that your change fixes the issue. I believe it does, as it appears use of limit keyword is currently broken for the method. You'd probably want to add a test case near https://github.com/ruby/date/blob/c2d9cc29280e0eabb0bc72175c80704f1737a9fb/test/date/test_date_strftime.rb#L386 —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>

[pelbyl]

@jeremyevans please take a look at the new tests, especially

b6974b0#diff-81966e1c9ca334eec0c25c83971b5ca20f9d52e5535b076db6f288b3a18ef996R415

[jeremyevans]

Looks good, thanks for the patch!