allow Protobuf::Message based classes to be inherited#247
allow Protobuf::Message based classes to be inherited#247localshred merged 1 commit intoruby-protobuf:masterfrom
Conversation
|
see non-whitespace changes |
|
hmm... looks like a timing error on a test |
|
I should have said 'looks like a timing error on a [non-related] test'. I suspect if you kick travis to re-run the tests things will run just fine. |
|
K, will do (thanks for the ping :)). |
|
Now it's failing due to formatting issues (rubocop) https://travis-ci.org/localshred/protobuf/jobs/49230691 |
|
hey @localshred ; very odd. when I run The rubocop errors shown in travis have nothing to do with this PR; the files flagged weren't modified by this PR. I did a quick scan and the Any thoughts on what is going on? |
|
Ya, ran your branch locally and everything seems ok. To say I'm unhappy with the state of our tests is an understatement. Thanks for the code! |
allow Protobuf::Message based classes to be inherited
|
Released under v3.4.4. |
|
Finally got rubocop to shut up, tests are now passing on travis. |
addresses #246
NOTE:
I wrapped most of the methods in
Protobuf::Message::FieldsinClassMethodsto keep it clearer about what is going where. If you view the diff in github without whitespace changes you'll see the minimal changes to that class.