Skip to content

allow Protobuf::Message based classes to be inherited#247

Merged
localshred merged 1 commit intoruby-protobuf:masterfrom
skippy:fix-class-inheritance
Feb 18, 2015
Merged

allow Protobuf::Message based classes to be inherited#247
localshred merged 1 commit intoruby-protobuf:masterfrom
skippy:fix-class-inheritance

Conversation

@skippy
Copy link
Copy Markdown
Contributor

@skippy skippy commented Feb 2, 2015

addresses #246

NOTE:

I wrapped most of the methods in Protobuf::Message::Fields in ClassMethods to keep it clearer about what is going where. If you view the diff in github without whitespace changes you'll see the minimal changes to that class.

@skippy
Copy link
Copy Markdown
Contributor Author

skippy commented Feb 2, 2015

see non-whitespace changes

@skippy
Copy link
Copy Markdown
Contributor Author

skippy commented Feb 2, 2015

hmm... looks like a timing error on a test

@skippy
Copy link
Copy Markdown
Contributor Author

skippy commented Feb 16, 2015

I should have said 'looks like a timing error on a [non-related] test'. I suspect if you kick travis to re-run the tests things will run just fine.

@localshred
Copy link
Copy Markdown
Contributor

K, will do (thanks for the ping :)).

@localshred
Copy link
Copy Markdown
Contributor

Now it's failing due to formatting issues (rubocop) https://travis-ci.org/localshred/protobuf/jobs/49230691

@skippy
Copy link
Copy Markdown
Contributor Author

skippy commented Feb 18, 2015

hey @localshred ; very odd. when I run bundle exec rake locally it runs with no errors (using ruby 2.2, 2.1.5, 2.1, and 2.0.0-p598 on osx 10.10).

The rubocop errors shown in travis have nothing to do with this PR; the files flagged weren't modified by this PR. I did a quick scan and the Rakefile and .travis.yml all seem to be in order.

Any thoughts on what is going on?

@localshred
Copy link
Copy Markdown
Contributor

Ya, ran your branch locally and everything seems ok. To say I'm unhappy with the state of our tests is an understatement. Thanks for the code!

localshred added a commit that referenced this pull request Feb 18, 2015
allow Protobuf::Message based classes to be inherited
@localshred localshred merged commit 96fe1ba into ruby-protobuf:master Feb 18, 2015
@localshred
Copy link
Copy Markdown
Contributor

Released under v3.4.4.

@localshred
Copy link
Copy Markdown
Contributor

Finally got rubocop to shut up, tests are now passing on travis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants