allow queue size to be configurable and use an array as local queue as t...#213
Merged
abrandoned merged 2 commits into3-0-stablefrom Aug 26, 2014
Merged
allow queue size to be configurable and use an array as local queue as t...#213abrandoned merged 2 commits into3-0-stablefrom
abrandoned merged 2 commits into3-0-stablefrom
Conversation
…s the broker is single threaded
Contributor
Author
|
I moved to checking the negative because |
Contributor
Author
|
also updated it to reflect the zmq and server nature of the PB env var |
abrandoned
added a commit
that referenced
this pull request
Aug 26, 2014
allow queue size to be configurable and use an array as local queue as t...
Contributor
|
🆒 |
Contributor
|
Hi folks, this PR broke tests. Sadly, at the time of this PR tests were not being run in travis. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...he broker is single threaded
We were using a
Queuein the Zmq broker, but the broker runs in it's own thread so access does not need to be synchronized when storing data for the local queueAlso elevated the backlog of the broker queue to be managed by an environment variable as we are seeing greater throughput with queue size being 25% of worker size which is also configurable via ENV variables
@localshred