Merged
Conversation
equivalence1
force-pushed
the
ruby-attach-to-process
branch
6 times, most recently
from
bb9029a to
82d6f3c
Compare
equivalence1
force-pushed
the
ruby-attach-to-process
branch
from
82d6f3c to
93f7156
Compare
equivalence1
force-pushed
the
ruby-attach-to-process
branch
from
93f7156 to
72b1c4a
Compare
bin/gdb_wrapper
Outdated
| options.pid = pid | ||
| end | ||
|
|
||
| opts.on("--sdk-path SDK_PATH", "path to ruby interpreter") do |sdk_path| |
Member
There was a problem hiding this comment.
SDK is IDE concept, I'd suggest using something like --ruby-path
added 2 commits
August 9, 2016 14:16
…in separate file. `enable_trace_points` call (wrong) replaced with empty_file loading (ugly but should always work). Including gems into $LOAD_PATH.
Contributor
Author
|
@denofevil pushed some fixes |
bin/gdb_wrapper
Outdated
| unless options.sdk_path | ||
| $stderr.puts "You must specify SDK_PATH of ruby interpreter" | ||
| unless options.ruby_path | ||
| $stderr.puts "You must specify RUBY_PATH of ruby interpreter" |
Member
There was a problem hiding this comment.
How about "You should specify path to the ruby interpreter"?
…ebugger.cli_debug = options.cli_debug; bug fix: check RUBYOPT and $: if they already contain our paths (relevant in case of attaching several time to some process); bug fix: calling `prepare_context` instead of `enable_tracepoints`; calling `init_variables` to reset all debase variables from previous attaching
bin/gdb_wrapper
Outdated
| commands_list << "cont" | ||
| $pid = options.pid | ||
| $last_bt = '' | ||
| $gdb_tmp_file = '/tmp/gdb_out.txt' |
Member
There was a problem hiding this comment.
It's better to use tempfile.rb instead. It's cross-platform and generates unique names, so you won't need line 69
…is is needed for attach mode: if we detached `pre_child` should not be called in `fork` and `exec`
equivalence1
force-pushed
the
ruby-attach-to-process
branch
from
e907772 to
c066895
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@denofevil