Merged
Conversation
Pre 2.0 versions of Ruby cannot handle keyword arguments and thus the introduction of a socket_path keyword argument, even if defaulted to nil, will cause errors. Solution: Add `start_server_unix` and `start_control_unix` functions and then share implementation with the original methods by refactoring the implementations into common methods.
tdyas
force-pushed
the
unix_socket_support
branch
2 times, most recently
from
92670e2 to
825ae23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow debugger clients to connect to the in-process debug server over a UNIX domain socket instead of a local TCP socket which further ensures that only local processes may connect to the debug server.
This PR adds
start_server_unixandstart_control_unixvariants of thestart_serverandstart_controlfunctions, respectively, which take a socket path instead of a host/port pair. These new methods are necessary in order for the PR to work with older versions of Ruby.The tests have been refactored enough to allow testing both the TCP socket and UNIX domain socket variants with the same test code.
[See https://github.com//pull/166 for the original PR which can be closed.]