Conversation
viuginick1
force-pushed
the
test-fixes-clean
branch
2 times, most recently
from
be2a192 to
7d56412
Compare
valich
reviewed
Dec 5, 2017
| @@ -1,3 +1,9 @@ | |||
| if RUBY_VERSION < '2.0' || defined?(JRUBY_VERSION) | |||
| require 'ruby-debug-base' | |||
Contributor
|
Regarding the last commit: so, why have these last tests been failing? It's very suspicious to me that it's only mac and ruby 2.5 affected |
valich
reviewed
Dec 18, 2017
test-base/test_base.rb
Outdated
| def assert_suspension(exp_file, exp_line, exp_frames, exp_thread_id=1) | ||
| suspension = read_suspension | ||
| assert_equal(exp_file, suspension.file) | ||
| assert_true(File.identical?(exp_file, suspension.file)) |
Contributor
There was a problem hiding this comment.
Is this change needed after the last commit (using realpath)?
viuginick1
force-pushed
the
test-fixes-clean
branch
from
9ead632 to
91f92e2
Compare
(cherry picked from commit ac9e8b1) (cherry picked from commit a492b11)
Sometimes it is evaluating before the ruby-debug-ide.rb, from where it normally requires
This fixes skipped stepping on oneliner blocks
viuginick1
force-pushed
the
test-fixes-clean
branch
from
1e08402 to
b916561
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in case of
debasefront end are related to differences in the logging of control frames. For 'debase' case there are two debugger frames (rdebug-ide and ruby-debug-ide). As a consequence, it is necessary to increase the number of frames by 2 in all the corresponding asserts.test/ruby-debug/xml_printer_test.rb:69 need to be investigated.
(cherry picked from commit ac9e8b1)
(cherry picked from commit a492b11)