Repository navigation
fix(hooks): preserve host checks when settings cannot be loaded - #4680
Open
Ehsan-hash wants to merge 1 commit into
Open
Ehsan-hash wants to merge 1 commit into
Ehsan-hash wants to merge 1 commit into
Conversation
📊 Automated PR Analysis
SummaryFixes a fail-open bug in RTK's hook permission loading: when a Cursor or Droid settings file exists but fails to be read or parsed, the code now fails closed (denies all commands) instead of silently treating the error as 'no rules'. Also distinguishes missing/empty settings files from read/parse errors, and preserves existing behavior for Gemini. Review Checklist
Linked issues: #4652 Analyzed automatically by wshm · This is an automated analysis, not a human review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4652.
Test plan
cargo fmt --all -- --check, standalone proxy formatting,cargo clippy --all-targets -- -D warnings, andcargo test --all(5,006 passed, 8 ignored).6c1af5fb; they pass with this change.git diffrewrite distinguishes pass-through from an already-unrewritable command.Prepared with AI assistance and independently reviewed. Local checks cover RTK's hook protocol; they do not claim a live Cursor or Droid permission decision. This hook change still needs the repository's two maintainer reviews.