Repository navigation
Conversation
|
|
📊 Automated PR Analysis
SummaryThis PR fixes two tests that failed on machines where the environment differs from the original author's setup. One test assumed chmod 0555 makes a directory unwritable, which doesn't hold for root or CAP_DAC_OVERRIDE processes, so it now probes writability directly and skips with a note if the user can bypass permissions. The other test asserted a specific git error message wording that varies across git versions, so it now compares against the actual git invocation's stderr instead of a pinne… Review Checklist
Analyzed automatically by wshm · This is an automated analysis, not a human review. |
KuSh
force-pushed
the
fix/env-dependent-tests
branch
2 times, most recently
from
October 9, 2026 20:37
e0839d8 to
bcf1165
Compare
git_log_malformed_digit_run_propagates_real_git_error pinned git's "not an integer" wording, which differs across git versions (2.43 says "not a non-negative integer"). Assert that rtk's stderr carries the stderr of the raw git it runs next to instead. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
KuSh
force-pushed
the
fix/env-dependent-tests
branch
from
October 19, 2026 16:16
bcf1165 to
4c0f7c0
Compare
KuSh
changed the title
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git_log_malformed_digit_run_propagates_real_git_error(tests/guard_integration_test.rs) asserted git's own wording,"not an integer". That message differs between git versions: git 2.43 printsfatal: '5x': not a non-negative integer, so the test failed there. It now asserts that rtk's stderr contains the stderr of the rawgit log -5xthe test already runs next to it, both underLC_ALL=C, per the "never assert on a third-party tool's wording" rule in.claude/rules/cli-testing.md.Test-only change: no production code is touched.
Test plan
cargo fmt --all --check,cargo clippy --all-targetsandcargo test --all --no-fail-fast: all green on the PR head, rebased ondevelop