Repository navigation
fix(tests): repair the tests broken by the #4001 and #4005 merges - #4460
Merged
Merged
Conversation
…ew text glab_argv_test spawned the binary from CARGO_BIN_EXE_rtk, which the isolation scan refuses; it now goes through common::rtk_command(). BLOB_HINT in guard_integration_test still held the pre-`rtk proxy` hint, so two git show tests failed and a third passed vacuously. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
📊 Automated PR Analysis
SummaryFixes CI breakage on develop caused by the merge of #4001 and #4005: glab_argv_test.rs now spawns the binary via common::rtk_command() so it passes the test-isolation scan while still pinning HOME/RTK_DB_PATH, and BLOB_HINT in guard_integration_test.rs is updated to match the Review Checklist
Analyzed automatically by wshm · This is an automated analysis, not a human review. |
aeppling
approved these changes
Oct 6, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
develop's CI is red since #4001 and #4005 were merged: each passed on its own branch, but the merge of the two does not.
tests/glab_argv_test.rs(fix(glab): tokenize glab args instead of walking them by hand #4005) spawned the binary throughCARGO_BIN_EXE_rtk, which thecore::test_isolation::tests_that_spawn_rtk_isolate_their_datascan refuses because the child writes to the real~/.local/share/rtk/. It now goes throughcommon::rtk_command(), which also pins HOME and the data paths, so the test's ownHOMEandRTK_DB_PATHoverrides are dropped.BLOB_HINTintests/guard_integration_test.rs(refactor(git): tokenize git show's objects instead of walking clusters #4001) still held the hint text from before fix(git): stop show reporting on HEAD and log capping in silence #4117 routed it throughrtk proxy. Twogit_show_*tests failed on it, andgit_show_blob_spec_after_double_dash_is_a_pathspec_not_an_objectpassed without checking anything, since its negative assertion could never match the old text.split_for_permissionsand its row in the segmenter table now say that the operand taken along with the redirect is the one attached to the operator. Comment-only.No behaviour change in
src/.Test plan
cargo fmt --all -- --check,cargo clippy --all-targetsandcargo test --all --no-fail-faston this branch: 4183 passed, 0 failed.--include-ignoredalso passes, and the two touched integration files pass underLC_ALL=de_DE.UTF-8.🤖 Generated with Claude Code