Repository navigation
Conversation
rtk jest removed every argument equal to `run`, so `rtk jest -t run src/ok.test.js` spawned `jest -t src/ok.test.js`: the name pattern was lost and the path filter became the pattern. Like the `jest run` rewrite prefix, treat `run` as a subcommand only when it comes first.
|
|
📊 Automated PR Analysis
SummaryFixes a bug in the Review Checklist
Linked issues: #4431 Analyzed automatically by wshm · This is an automated analysis, not a human review. |
Author
|
Hi! Gentle ping on this small fix. Happy to rebase or add a test case if that helps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runargument anywhere in the line, so-t runloses its value #4431.rtk jest -t run src/ok.test.jswas runningjest -t src/ok.test.js, because everyrungot stripped, not just the subcommandrunis only dropped when it's the first arg, same as thejest runrewrite ruleHeads up: #3777 still has the
arg == "run"check, so whichever of the two lands second will need a small rebase.Test plan
cargo fmt --all && cargo clippy --all-targets && cargo testjeston PATH that prints its args,rtk jest -t run src/ok.test.jsnow passes-t run src/ok.test.jsthrough,rtk jest run src/ok.test.jsstill drops the leadingrun3 tests (
guard_integration_testx2 and one inrewrite_host_scoping) fail for me locally, but they fail ondeveloptoo, looks like my git version.