Repository navigation
Conversation
cargo install cargo-audit resolves tinyvec 1.13.0 (released 2026-09-03), which fails to compile ("cannot find macro vec in this scope"), so the Security Scan job dies before the audit runs. --locked uses cargo-audit's own lockfile, which pins a tinyvec that builds. Verified locally: unlocked reproduces the error, locked installs cargo-audit 0.22.2.
…e pointer Since upstream's find started disclosing hidden and gitignored matches (765b270, 68dc719), rtk find --max N ends with a "... (N filtered)" note and a "[see remaining: tail -n +1 <tee log>]" pointer. The benchmark's count_find_names/count_find_total awk counted every word on those two lines as a name, so the --max 10 cap read as 19 names and --max 100 as 109, and both cap checks failed on develop (fork run 33812431685; upstream develop fails the same two checks). Skip both lines in both counters. Locally in this repo: 19/109 -> 10/100 names, total 494 -> 485.
|
Rebased by merge (append-only) onto current What remains is the single line from the original description: run: cargo install cargo-audit --locked
Happy to retitle to |
…t half The benchmark find-count half (a990b99) is superseded by d952a6b (rtk-ai#3863), which skips the same disclosure-note and tee-pointer lines; scripts/benchmark.sh is upstream's again. What remains is the single ci.yml line: `cargo install cargo-audit --locked`. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Fixes #3860. Two CI-only changes, one commit each, that make
developCI green again.scripts/benchmark.sh: count find names onlySince #3854
rtk find --max Nends with a... (N filtered)disclosure note and a[see remaining: tail -n +1 <tee log>]pointer.count_find_names/count_find_totalcounted every word on those lines as a name, so thefind --max 10/100 capchecks read 19 and 109 names. Both counters now skip the two lines, anchored to their exact shapes (find_cmd.rsfiltered_hint,tee.rsforce_tee_tail_hint), next to the existing+N more/ext:skips.Verified against a
developbuild in this repo, feedingrtk find '*' --max Nthrough the two functions before / after:Edge shapes checked:
... (1000+ filtered)(theFILTERED_CAPform) is skipped; tee disabled means no pointer line and nothing to skip; a real entry named... (odd) namestill counts. The--maxcap itself is honoured (+475 moreafter 10 names); the counters were the bug, notfind..github/workflows/ci.yml:cargo install cargo-audit --lockedtinyvec 1.13.0 (published 2026-09-03) does not compile under an unlocked resolve, so a cache miss on the
Security Scanjob now dies before the audit runs.--lockeduses cargo-audit's own lockfile (tinyvec 1.11.0). Verified locally: unlocked exits 101 with the same error, locked installs cargo-audit 0.22.2. The advisory database is fetched at run time, so a locked build cannot make the audit stale.Not changed
The
golangci-lintbenchmark row on the same runs is a separate failure (Go 1.27 on the runner) and is not touched here.release.ymlhas two more unlockedcargo installsteps with the same exposure; left for a separate change.