Repository navigation
fix(phpt): use LazyLock and RtkRule::DEFAULT so develop builds - #3798
Merged
Merged
Conversation
pszymkowiak
approved these changes
Sep 1, 2026
pszymkowiak
left a comment
Collaborator
There was a problem hiding this comment.
Verified locally: develop at e8541d1 fails with exactly the 7 reported errors (lazy_static macro gone + missing pipeline_final_safe). On this branch: cargo fmt --check clean, clippy 0 warnings, 2965 tests pass. Minimal, correct repair of the two stale touchpoints — and the ..RtkRule::DEFAULT change future-proofs the rule. Agreed on the process note: requiring branches up to date before merge would have caught this. LGTM.
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
developdoes not compile since #1503 merged (e8541d1). Release PR #3721 and every build job fail on it.PR #1503 was authored 2026-04-24 and merged 2026-08-31 without a rebase. Two things changed underneath it in that window:
5269df7removedlazy_staticfromCargo.tomlin favour ofLazyLock.phpt_cmd.rsstill callslazy_static::lazy_static!, so the macro fails to expand andSTATUS_RE,STAT_RE,NUMBER_OF_TESTS_REandTIME_REare never defined.RtkRulegainedpipeline_final_safe. The new rule inrules.rsspells its fields out rather than using..RtkRule::DEFAULT, so it misses the new field.This repairs @iliaal's feature rather than reverting it — the phpt filter itself is fine, only these two touchpoints went stale.
Changes
phpt_cmd.rs: the four statics becomeLazyLock, matching the other 25 files and theLazyLockrule in CLAUDE.md.rules.rs: use..RtkRule::DEFAULTlike every neighbouring entry, so future fields do not break it again.Verification
cargo fmt --all --checkclean,cargo clippy --all-targets0 warnings,cargo test --all2965 passed, 0 failed — the phpt tests run for the first time, since compilation previously stopped before them.Process note
Checks on #1503 passed against April's
develop, not the current one. Requiring branches to be up to date before merge would prevent this class.