Repository navigation
feat(svn): add first-class Subversion support - #3796
Open
Raymondriter wants to merge 5 commits into
Open
Raymondriter wants to merge 5 commits into
Raymondriter wants to merge 5 commits into
Conversation
Signed-off-by: Raymond Riter <rpr2998@gmail.com>
Signed-off-by: Raymond Riter <rpr2998@gmail.com>
Raymondriter
marked this pull request as ready for review
September 4, 2026 14:46
Signed-off-by: Raymond Riter <rpr2998@gmail.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
Author
|
Brought this up to date with current |
Signed-off-by: Raymond Riter <rpr2998@gmail.com>
Signed-off-by: Raymond Riter <rpr2998@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rtk svncommand with conservativesvn logcompaction and exact passthrough for unsupported, detailed, structured, search, and mutating shapes.Closes #3795.
Initial behavior
svn logdefaults to 10 revisions and emits a recovery hint when the limit is reached.-l/--limit,-r/--revision, and-c/--changeremain caller-controlled.svn status,svn diff, global-option-first invocations, and unknown or mutating subcommands are native passthrough.--xml,--incremental,--diff,--quiet,--verbose, merge-history, revision-property, and search log shapes are native passthrough and are not hook-rewritten.Test plan
Verification refreshed September 29, 2026, at
6d65ca6, after merging currentdevelop. The refresh resolves routing conflicts after upstream renamed the Git command module, restores the SVN module declaration, and reuses the shared signal relay for the custom log capture path.cargo fmt --all -- --checkgit diff --checkcargo clippy --all-targets --all-features -- -D warningscargo test --all --quiet: 3,842 unit tests passed, 8 ignored; all integration suites passedbash scripts/check-test-presence.sh upstream/developPrivate review's cancellation finding is fixed: the filtered SVN child receives the cancellation signal and is reaped, and RTK preserves signal termination after collecting output. No hosted CI pass or maintainer approval is claimed.
Baseline and scope
The previous PHPT compile blocker was fixed upstream in
a419e691and is now inherited through thedevelopmerge. No separate PHPT repair is part of this feature's diff. The published SVN commit is preserved; the refresh adds a signed-off merge commit without rewriting branch history.Local verification is complete. GitHub-hosted CI and maintainer review are still required before merge; the previous fork CI run awaited maintainer approval.
Safe SVN diff compaction remains deliberately deferred; #3769 and #3788 track adjacent unified-diff region work. This PR only compacts supported text logs.