Repository navigation
Conversation
guyoron1
force-pushed
the
fix/git-log-combined-n-flag
branch
from
August 14, 2026 19:03
3766d17 to
4053395
Compare
`rtk git log -n20` was capped at 10 commits because only the separate-token `-n 20` counted as a user limit (rtk-ai#2665). The shared arg tokenizer fixed that without a test naming the case, so pin it: the parser and the limit detection on the glued form, and the compact listing end to end. Refs rtk-ai#2665
guyoron1
force-pushed
the
fix/git-log-combined-n-flag
branch
from
September 21, 2026 12:20
4053395 to
7cfe362
Compare
Contributor
Author
|
Checked against current develop: #2665 itself is fixed on develop and can be closed. #4148 and #4152 also edit |
This was referenced Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #2665
rtk git log -n20used to return 10 commits because the glued-n<N>form wasn't recognised. That was fixed on develop by the shared arg tokenizer (#3681), so the code change this PR originally carried is obsolete and has been dropped.What is left is the coverage, since nothing on develop pins the glued form (the existing tests cover
-20,-n 15and--max-count):test_parse_user_limit_n_combined(parser +has_limit_flag)-n20added to the shapes ina_user_limit_or_a_revision_range_is_not_capped(raw path)a_glued_n_limit_is_the_users_limit_on_the_compact_listing(compact path: unbounded = 10;-n20,-n 20and-20= 20)All three fail if the reported bug is reintroduced (checked by making
-ncount only when its value is a separate token). Issue #2665 itself is fixed on develop and can be closed.cargo fmt --all -- --check,cargo clippy --all-targets(0 warnings),cargo test --all(all pass)