Repository navigation
Conversation
|
This pull request has been automatically marked as stale due to 90 days of inactivity. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. Your contribution is very much appreciated — we're sorry we haven't been able to review it yet. |
|
Thanks for the report and the fix. This is covered on develop by #3603 (merged 2026-08-26), which reworked rtk find to parse find's real grammar; -print is now recognised as a native action and the command runs through to real find, so the 'unknown flag -print, ignored' warning is gone. Running rtk find . -maxdepth 1 -name '*.md' -print against develop produces plain results with no warning, and find_cmd.rs was rewritten enough that this branch no longer applies. Closing as covered, but please comment or reopen if you still see the warning on a case we missed. |
Problem
rtk find . -name "*.rs" -printwarns:The
-printflag is the default action in standardfind(1). RTK already prints matches, so this should be a no-op.Root Cause
has_native_find_flags()didn't recognize-print, causing it to fall through to the "unknown flag" warning handler.Changes
-printtohas_native_find_flags()so RTK enters native parsing mode-printcase inparse_native_find_args()as a no-op (RTK already prints matches)-printbehaviorVerification
Notes
-print0(which is inUNSUPPORTED_FIND_FLAGS— different semantics)