Skip to content

Fix #1071 - #1386

Closed
PicoJr wants to merge 1 commit into
rtk-ai:developfrom
PicoJr:fix-1071
Closed

PicoJr wants to merge 1 commit into
rtk-ai:developfrom
PicoJr:fix-1071

Conversation

@PicoJr

@PicoJr PicoJr commented Apr 18, 2026

Copy link
Copy Markdown

Summary

Test plan

  • Manual testing: rtk <command> output inspected
rtk on  fix-1071 is 📦 v0.34.3 via 🦀 v1.92.0 
❯ git show ca7fbeb:test.bin | md5sum
3df17d08f5e181ff83982d9334a58579  -

rtk on  fix-1071 is 📦 v0.34.3 via 🦀 v1.92.0 
❯ ./target/debug/rtk git show ca7fbeb:test.bin | md5sum
3df17d08f5e181ff83982d9334a58579  -

AI Use disclosure:

  • I used AI to analyze the code and write the fix
  • I reviewed the code and tested the fix manually
  • I also used AI to do additional code review
  • This PR was written manually without the use of AI

I ran cargo fmt --all && cargo clippy --all-targets && cargo test on my commit

@CLAassistant

CLAassistant commented Apr 18, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@pszymkowiak pszymkowiak added bug Something isn't working effort-small Quelques heures, 1 fichier filter-quality Filter produces incorrect/truncated signal labels Apr 18, 2026
@pszymkowiak

Copy link
Copy Markdown
Collaborator

[w] wshm · Automated triage by AI

📊 Automated PR Analysis

🐛 Type bug-fix
🟢 Risk low

Summary

Fixes issue #1071 where rtk git show <rev>:<path> produced incorrect filtered content for binary blobs. The fix passes binary blob shows directly through to git instead of capturing and printing the output, preserving binary data integrity. The issue of rtk git show <rev> (without colon) for binary blobs remains unresolved.

Review Checklist

  • Tests present
  • Breaking change
  • Docs updated

Linked issues: #1071


Analyzed automatically by wshm · This is an automated analysis, not a human review.

@KuSh

KuSh commented Oct 3, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the fix. Since #3265 (merged 2026-09-11), rtk git show <rev>:<path> detects blob objects with a cat-file probe and writes their bytes through unchanged, so a binary blob now comes out byte-identical to plain git show; the code this PR edits was replaced by that path. If you still see a difference on a recent build, please comment and this can be reopened.

@KuSh KuSh closed this Oct 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working effort-small Quelques heures, 1 fichier filter-quality Filter produces incorrect/truncated signal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rtk git show differ from git show on binary files

4 participants