You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
rtk git show <rev> without the : where <rev> corresponds to a binary blob still produces incorrect filtered content
Test plan
Manual testing: rtk <command> output inspected
rtk on fix-1071 is 📦 v0.34.3 via 🦀 v1.92.0
❯ git show ca7fbeb:test.bin | md5sum
3df17d08f5e181ff83982d9334a58579 -
rtk on fix-1071 is 📦 v0.34.3 via 🦀 v1.92.0
❯ ./target/debug/rtk git show ca7fbeb:test.bin | md5sum
3df17d08f5e181ff83982d9334a58579 -
AI Use disclosure:
I used AI to analyze the code and write the fix
I reviewed the code and tested the fix manually
I also used AI to do additional code review
This PR was written manually without the use of AI
I ran cargo fmt --all && cargo clippy --all-targets && cargo test on my commit
Fixes issue #1071 where rtk git show <rev>:<path> produced incorrect filtered content for binary blobs. The fix passes binary blob shows directly through to git instead of capturing and printing the output, preserving binary data integrity. The issue of rtk git show <rev> (without colon) for binary blobs remains unresolved.
Thanks for the fix. Since #3265 (merged 2026-09-11), rtk git show <rev>:<path> detects blob objects with a cat-file probe and writes their bytes through unchanged, so a binary blob now comes out byte-identical to plain git show; the code this PR edits was replaced by that path. If you still see a difference on a recent build, please comment and this can be reopened.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugSomething isn't workingeffort-smallQuelques heures, 1 fichierfilter-qualityFilter produces incorrect/truncated signal
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rtk git show <rev>:<path>rtk git show <rev>without the:where<rev>corresponds to a binary blob still produces incorrect filtered contentTest plan
rtk <command>output inspectedAI Use disclosure:
I ran
cargo fmt --all && cargo clippy --all-targets && cargo teston my commit