Repository navigation
fix(license): use a valid SPDX identifier in package and formula metadata - #1333
Merged
Merged
Conversation
Contributor
|
This pull request has been automatically marked as stale due to 90 days of inactivity. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. Your contribution is very much appreciated — we're sorry we haven't been able to review it yet. |
…data `Apache 2.0` is not a valid SPDX expression, so `cargo publish` rejects the manifest and `brew audit` flags the generated formula. Use the `Apache-2.0` identifier in both places. The release workflow regenerates `Formula/rtk.rb` on every release, so its heredoc was overwriting the already-correct value checked in at `Formula/rtk.rb:10`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
KuSh
force-pushed
the
docs/license-consistency
branch
from
September 6, 2026 23:52
4fb31d0 to
ad8cc55
Compare
KuSh
changed the title
KuSh
approved these changes
Sep 6, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Apache 2.0is not a valid SPDX expression. It appears in two places that feed package metadata:Cargo.toml—cargo publishrejects the manifest on an unparseablelicensefield..github/workflows/release.yml— the heredoc that generates the Homebrew formula. Since it regeneratesFormula/rtk.rbon every release, it silently overwrites the already-correctlicense "Apache-2.0"checked in atFormula/rtk.rb:10, andbrew auditflags the result.Change
Use the
Apache-2.0identifier in both. Two lines, no behaviour change.cargo metadata --no-depsnow reports"license":"Apache-2.0".Related issue
Related: #1064 — the license inconsistency this PR started from. That issue was already closed as completed on 2026-09-05, so this uses a plain reference rather than a closing keyword.
Scope note
This PR originally also aligned the MIT references in the READMEs and
Cargo.toml.develophas since fixed all of those independently — and more completely, since it also coversREADME_pt.md, which this PR never touched. After rebasing ontodevelop, only the SPDX identifier remained unfixed, so that is all this PR now carries.The one remaining
MITmention in the repo isSECURITY.md:127("License: MIT or Apache-2.0 compatible"). That is the dependency-acceptance policy, not a claim about rtk's own license, and is left as-is.