Repository navigation
Conversation
Adi-ty
marked this pull request as ready for review
November 20, 2026 09:33
Adi-ty
requested review from
AnuragVasanwala,
aryanjasala and
justlevine
as code owners
November 20, 2026 09:33
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds an optional type-check to
ci-lint-js.yml, so a TypeScript project can runtscthrough the shared workflow instead of a hand-written job besidewp-ci.yml. It is off unlesstypecheck-commandis set.Closes
Part of #51: the
ci-lint-jsgap "ESLint only, no TypeScript type check".Changes
ci-lint-js.ymlgainstypecheck-command(default"", which skips it). AType-checkstep runs it after ESLint over the whole project, whatever changed, because a type error can surface in a file the change did not touch.npm cisucceeded, so one run reports lint errors and type errors together.wp-ci.ymlforwardstypecheck-commandtolint-js.name: ESLint, so no check name changes.examples/ci-lint-js.ymland the README index row show the new input.How I verified
Acceptance criteria
Runtime behavior
typecheck-commandempty: lint-js runs the same steps as beforeType-checkCode quality
Housekeeping
CHANGELOG.mdfrom itexamples/<workflow>.ymladded or updated to match any input changeyamllint,actionlintandbin/check-workflows.shpass locallyReviewer notes
npm ci, and needs no new job id in the presets,knownorskip..ts,.tsxandtsconfig*.jsoncount there from@rtcamp/wp-tooling2.1.0 (feat(detect-changes): count ES-module and TypeScript files in the js bucket wp-tooling#80). Until that is on npm, a PR that changes only TypeScript files skips lint-js, and with it the type-check.Conventions: AGENTS.md · PR process: CONTRIBUTING.md